Dropping virsh, added libvirt providers #599
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change was not shipped in Foreman 1.11, so the 1.11 docs shouldn't be changed. It's already on the 1.12 checklist at #555, please re-submit a PR then. Any changes to the installer docs must be made in the installer Puppet modules themselves, the docs are autogenerated. |
|
I rebased onto 1.12. |
|
Hmmm I click Reopen but the button is now gray. Looks like stuck (no merge button). Shall I reopen new one, or can you merge manually? |
|
Please just open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflects changes in
theforeman/smart-proxy@6798dc5
puppet changes in
theforeman/puppet-foreman_proxy#240