Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the 'class' argument passed to add_settings_field() to 'callback' #6

Merged
merged 2 commits into from Apr 25, 2015

Conversation

Projects
None yet
2 participants
@DrewAPicture
Copy link
Contributor

commented Apr 25, 2015

In WordPress 4.2, a new field was added to add_settings_field() with a key of 'class'. The purpose of the new argument was to make it possible to specify a CSS class for the setting container.

Unfortunately, the introduction of this new argument caused a conflict with a separate 'class' argument already in use. This PR renames that to 'callback' and all is right in the world.

See [31560] for where the new argument was added to core, and [31592] where the new argument was documented in the changelog for add_settings_field().

This fixes #5.

DrewAPicture added some commits Apr 25, 2015

Rename the 'class' argument passed to add_settings_field() to 'instan…
…ce'.

In WordPress 4.2, a new field was added to `add_settings_field()` with a key of 'class'. The purpose of the new argument was to make it possible to specify a CSS class for the setting container.

Unfortunately, the introduction of this new argument caused a conflict with a separate 'class' argument already in use. This PR renames that to 'instance' and all is right in the world.

@DrewAPicture DrewAPicture changed the title Rename the 'class' argument passed to add_settings_field() to 'instance' Rename the 'class' argument passed to add_settings_field() to 'callback' Apr 25, 2015

thefrosty pushed a commit that referenced this pull request Apr 25, 2015

Austin Passy
Merge pull request #6 from DrewAPicture/class_arg
Rename the 'class' argument passed to add_settings_field() to 'callback'

@thefrosty thefrosty merged commit 3da8069 into thefrosty:master Apr 25, 2015

thefrosty pushed a commit that referenced this pull request Apr 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.