Fix event handling in web-bluetooth api #62
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all events are stored in a global objects called
events
, indexed by the target Object. This causes a bug where all event listeners are shared between all objects. The reason is that JavaScript only support string indices for objects, and therefore,events[this]
actually becomesevents[this.toString()]
, and thetoString()
methods of all objects return '[object Object]'.So with the current implementation, all the event listeners are always stored inside
events['[object Object]']
, regardless of the actual object. The proposed fix simply stores the event listeners inside the object itself, in a property called__events
. Another option would be to use Symbol or WeakMap, if we target ES6 only.