Skip to content
This repository has been archived by the owner on Oct 5, 2022. It is now read-only.

llvm: bump llvm version to 12 #393

Merged
merged 1 commit into from
Aug 7, 2020
Merged

llvm: bump llvm version to 12 #393

merged 1 commit into from
Aug 7, 2020

Conversation

vince-fugnitto
Copy link
Member

What it does

Fixes: #386

The following pull-request bumps the LLVM version to 12 (latest dev branch), and fixes the build issue regarding packages not successfully found.

How to test

Verify that CI passes successfully.

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

@vince-fugnitto vince-fugnitto self-assigned this Aug 7, 2020
@vince-fugnitto vince-fugnitto marked this pull request as draft August 7, 2020 14:35
@vince-fugnitto vince-fugnitto marked this pull request as ready for review August 7, 2020 16:02
@marcdumais-work
Copy link
Member

I think #392 will need to go in first, before the next versions of theia-cpp and theia-full can compile correctly?

Copy link
Member

@marcdumais-work marcdumais-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @vince-fugnitto . I expect the CI failures for next images should be fixed once #392 is merged.

- the following commit bumps the `LLVM` version to `12`.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto
Copy link
Member Author

LGTM - thanks @vince-fugnitto . I expect the CI failures for next images should be fixed once #392 is merged.

@marcdumais-work I merged the @theia/languages PR and rebased this one so hopefully the build passes 🤞

@vince-fugnitto
Copy link
Member Author

The build for theia-full:next is failing due to @theia/rust which pulls @theia/languages.
Merging to continue resolving the builds...

@vince-fugnitto vince-fugnitto merged commit 5a67b04 into master Aug 7, 2020
@vince-fugnitto vince-fugnitto deleted the vf/llvm-fix branch August 7, 2020 19:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cpp, full] Problem fetching LLVM tools DEBIAN packages
2 participants