Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird state look when making a time graph view bigger #175

Closed
tahini opened this issue Oct 27, 2020 · 7 comments
Closed

Weird state look when making a time graph view bigger #175

tahini opened this issue Oct 27, 2020 · 7 comments
Labels
bug Something isn't working timeline-chart Involves changes in the timeline chart project: https://github.com/theia-ide/timeline-chart
Milestone

Comments

@tahini
Copy link
Contributor

tahini commented Oct 27, 2020

When resizing a time graph component to make it bigger, the new rows that are shown have some extra states or fillers or something. See the following screenshot

timeGraphResized

A quick bisect shows the problem arrived at commit e421d81 , but it may be due to updates in the timeline-chart that happened

@tahini tahini added bug Something isn't working timeline-chart Involves changes in the timeline chart project: https://github.com/theia-ide/timeline-chart labels Oct 27, 2020
@tahini tahini added this to the First MVP milestone Oct 27, 2020
@tahini
Copy link
Contributor Author

tahini commented Oct 27, 2020

@abhinava-ericsson @muddana-satish maybe you'll have an idea?

@ghost
Copy link

ghost commented Oct 27, 2020

I will have a look into it. Thanks for reporting.

@ghost
Copy link

ghost commented Oct 27, 2020

@tahini Do you have a trace where I can reproduce this issue consistently. I tried with several traces and none of them have this issue.

@ghost ghost self-assigned this Oct 27, 2020
@tahini
Copy link
Contributor Author

tahini commented Oct 27, 2020

I can reproduce consistently here with any trace... on linux/firefox. It's when resizing the view from the bottom right handle.

Here's a screencast of it

timeGraphResize

@bhufmann
Copy link
Collaborator

@tahini I've uploaded a patch in the timeline-chart eclipse-cdt-cloud/timeline-chart#100 (comment) repo that fixes issue #209. Could you please verify that this pull request also fixes this issue that you've reported? Thanks Bernd

@tahini
Copy link
Contributor Author

tahini commented Jan 22, 2021

It is fixed, thanks!

@tahini tahini closed this as completed Jan 22, 2021
@bhufmann
Copy link
Collaborator

Great, thanks for verifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working timeline-chart Involves changes in the timeline chart project: https://github.com/theia-ide/timeline-chart
Projects
None yet
Development

No branches or pull requests

2 participants