Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout migration from 2.0 to 3.0 version #5950

Closed
akosyakov opened this issue Aug 15, 2019 · 1 comment · Fixed by #5973
Closed

layout migration from 2.0 to 3.0 version #5950

akosyakov opened this issue Aug 15, 2019 · 1 comment · Fixed by #5973
Assignees
Labels
shell issues related to the core shell

Comments

@akosyakov
Copy link
Member

akosyakov commented Aug 15, 2019

As soon as we release next version (0.10.0) all existing layouts will be discarded. We could prevent it by introducing the layout migration mechanism. It will detect that restored layout data of version 2.0 and migrate them to version 3.0 before inflating from them.

Should we consider doing it? cc @svenefftinge

@akosyakov akosyakov added shell issues related to the core shell proposal feature proposals (potential future features) labels Aug 15, 2019
@akosyakov akosyakov self-assigned this Aug 15, 2019
@akosyakov akosyakov removed the proposal feature proposals (potential future features) label Aug 15, 2019
@akosyakov
Copy link
Member Author

Discussed with @svenefftinge, we will do it to avoid breaking existing layouts.

akosyakov added a commit that referenced this issue Aug 17, 2019
- introduced layout migration points
- implemented migration point for version 2 to discard all unversioned layouts (for backward compatibility)
- implemented scm migration point for version 3 to wrap scm widget into view container
- implemented explorer migration point for version 3 to wrap explorer widget into view container

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Aug 17, 2019
- introduced layout migration points
- implemented migration point for version 2 to discard all unversioned layouts (for backward compatibility)
- implemented scm migration point for version 3 to wrap scm widget into view container
- implemented explorer migration point for version 3 to wrap explorer widget into view container

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Aug 18, 2019
- introduced layout migration points
- implemented migration point for version 2 to discard all unversioned layouts (for backward compatibility)
- implemented scm migration point for version 3 to wrap scm widget into view container
- implemented explorer migration point for version 3 to wrap explorer widget into view container

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Aug 20, 2019
- introduced layout migration points
- implemented migration point for version 2 to discard all unversioned layouts (for backward compatibility)
- implemented scm migration point for version 3 to wrap scm widget into view container
- implemented explorer migration point for version 3 to wrap explorer widget into view container
- implemented problem migration point for version 3 to update the widget factory id

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Aug 21, 2019
- introduced layout migration points
- implemented migration point for version 2 to discard all unversioned layouts (for backward compatibility)
- implemented scm migration point for version 3 to wrap scm widget into view container
- implemented explorer migration point for version 3 to wrap explorer widget into view container
- implemented problem migration point for version 3 to update the widget factory id

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shell issues related to the core shell
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant