Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use Suave v1.0 #11

Merged
merged 15 commits into from Jan 24, 2016
Merged

Update to use Suave v1.0 #11

merged 15 commits into from Jan 24, 2016

Conversation

andredublin
Copy link
Contributor

@andredublin andredublin commented Jan 24, 2016

No description provided.

@@ -10,7 +10,7 @@ In this application we'll use server-side HTML templating with the help of a sep
> Note: As of the time of writing, `Suave.Experimental` is a separate package. It's likely that next releases of the package will include breaking changes. It's also possible that the modules we're going to use from within the package will be extracted to the core Suave package.

To use the package, we need to take a dependency on the following NuGet:
```install-package Suave.Experimental -version 0.28.1```
```install-package Suave.Experimental```
Copy link
Owner

@theimowski theimowski Jan 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather stick with pinned version (-version 1.0), to have content synced with code

Copy link
Contributor Author

@andredublin andredublin Jan 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added that in now

Signed-off-by: Andre Dublin <81dublin@gmail.com>
@theimowski
Copy link
Owner

theimowski commented Jan 24, 2016

Awesome! Did you indeed check that those changes make it work with Suave 1.0 ?
This repo will have to be updated as well, I still need to come up with a best way to do that.
For now, we'll have to mark that all permalinks to git tags (e.g. here at the end of file) show version 0.28.1

@andredublin
Copy link
Contributor Author

andredublin commented Jan 24, 2016

Yes, I worked through the book with the updated code and made sure the changes worked.

@theimowski
Copy link
Owner

theimowski commented Jan 24, 2016

Cool, can we please temporarily add (Suave 0.28.1) after every such git tag permalink? There should be 10 of them for each language. That's just to make the reader less confused

Signed-off-by: Andre Dublin <81dublin@gmail.com>
@andredublin
Copy link
Contributor Author

andredublin commented Jan 24, 2016

Links added

theimowski added a commit that referenced this pull request Jan 24, 2016
@theimowski theimowski merged commit e0af7ed into theimowski:master Jan 24, 2016
@theimowski
Copy link
Owner

theimowski commented Jan 24, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants