Skip to content

Update to use Suave v1.0#11

Merged
theimowski merged 15 commits intotheimowski:masterfrom
andredublin:master
Jan 24, 2016
Merged

Update to use Suave v1.0#11
theimowski merged 15 commits intotheimowski:masterfrom
andredublin:master

Conversation

@andredublin
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread en/views.md Outdated
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather stick with pinned version (-version 1.0), to have content synced with code

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added that in now

Signed-off-by: Andre Dublin <81dublin@gmail.com>
@theimowski
Copy link
Copy Markdown
Owner

Awesome! Did you indeed check that those changes make it work with Suave 1.0 ?
This repo will have to be updated as well, I still need to come up with a best way to do that.
For now, we'll have to mark that all permalinks to git tags (e.g. here at the end of file) show version 0.28.1

@andredublin
Copy link
Copy Markdown
Contributor Author

Yes, I worked through the book with the updated code and made sure the changes worked.

@theimowski
Copy link
Copy Markdown
Owner

Cool, can we please temporarily add (Suave 0.28.1) after every such git tag permalink? There should be 10 of them for each language. That's just to make the reader less confused

Signed-off-by: Andre Dublin <81dublin@gmail.com>
@andredublin
Copy link
Copy Markdown
Contributor Author

Links added

theimowski added a commit that referenced this pull request Jan 24, 2016
@theimowski theimowski merged commit e0af7ed into theimowski:master Jan 24, 2016
@theimowski
Copy link
Copy Markdown
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants