Update to use Suave v1.0 #11

Merged
merged 15 commits into from Jan 24, 2016

Conversation

Projects
None yet
2 participants
@andredublin
Contributor

andredublin commented Jan 24, 2016

No description provided.

en/views.md
@@ -10,7 +10,7 @@ In this application we'll use server-side HTML templating with the help of a sep
> Note: As of the time of writing, `Suave.Experimental` is a separate package. It's likely that next releases of the package will include breaking changes. It's also possible that the modules we're going to use from within the package will be extracted to the core Suave package.
To use the package, we need to take a dependency on the following NuGet:
-```install-package Suave.Experimental -version 0.28.1```
+```install-package Suave.Experimental```

This comment has been minimized.

@theimowski

theimowski Jan 24, 2016

Owner

I'd rather stick with pinned version (-version 1.0), to have content synced with code

@theimowski

theimowski Jan 24, 2016

Owner

I'd rather stick with pinned version (-version 1.0), to have content synced with code

This comment has been minimized.

@andredublin

andredublin Jan 24, 2016

Contributor

I've added that in now

@andredublin

andredublin Jan 24, 2016

Contributor

I've added that in now

pin version of Suave.Experimental
Signed-off-by: Andre Dublin <81dublin@gmail.com>
@theimowski

This comment has been minimized.

Show comment
Hide comment
@theimowski

theimowski Jan 24, 2016

Owner

Awesome! Did you indeed check that those changes make it work with Suave 1.0 ?
This repo will have to be updated as well, I still need to come up with a best way to do that.
For now, we'll have to mark that all permalinks to git tags (e.g. here at the end of file) show version 0.28.1

Owner

theimowski commented Jan 24, 2016

Awesome! Did you indeed check that those changes make it work with Suave 1.0 ?
This repo will have to be updated as well, I still need to come up with a best way to do that.
For now, we'll have to mark that all permalinks to git tags (e.g. here at the end of file) show version 0.28.1

@andredublin

This comment has been minimized.

Show comment
Hide comment
@andredublin

andredublin Jan 24, 2016

Contributor

Yes, I worked through the book with the updated code and made sure the changes worked.

Contributor

andredublin commented Jan 24, 2016

Yes, I worked through the book with the updated code and made sure the changes worked.

@theimowski

This comment has been minimized.

Show comment
Hide comment
@theimowski

theimowski Jan 24, 2016

Owner

Cool, can we please temporarily add (Suave 0.28.1) after every such git tag permalink? There should be 10 of them for each language. That's just to make the reader less confused

Owner

theimowski commented Jan 24, 2016

Cool, can we please temporarily add (Suave 0.28.1) after every such git tag permalink? There should be 10 of them for each language. That's just to make the reader less confused

add link to Suave tag 0.28.1
Signed-off-by: Andre Dublin <81dublin@gmail.com>
@andredublin

This comment has been minimized.

Show comment
Hide comment
@andredublin

andredublin Jan 24, 2016

Contributor

Links added

Contributor

andredublin commented Jan 24, 2016

Links added

theimowski added a commit that referenced this pull request Jan 24, 2016

Merge pull request #11 from andredublin/master
Update to use Suave v1.0

@theimowski theimowski merged commit e0af7ed into theimowski:master Jan 24, 2016

@theimowski

This comment has been minimized.

Show comment
Hide comment
@theimowski

theimowski Jan 24, 2016

Owner

Thanks!

Owner

theimowski commented Jan 24, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment