GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Add missing event handling for CDATA tags...
Add CDATA support
Add node_modules to gitignore, and remove python references.
fix mixed correction
put the cdata in the wrong place...
fix mixed cdata
put the cdata in the wrong spot.
The code patch looks good to me and ignoring node_modules is a good idea, but could you please remove all the other things in .gitattributes and .gitignore? Stuff that's specific to your editor or environment rather than node should be in your global gitignore file, not in project-specific files. Also, maybe you could (although it's not necessary) turn all these commits into one for adding some code and one for the gitignore or so, that would result in a cleaner history.
Honestly, not sure how I would go about undoing the commits... last time I tried, it simply did another commit with the reverted changes. I could do that, and re-do the changes that are needed... without the first couple lines in .gitattributes line endings get fubar'd in windows... can remove the rest in gitignore... not sure where the global prefs are in windows for that... I did the changes at work (windows), and am using github for windows client (believe it's a gui wrapper around the console version.