John Freeman thejohnfreeman

Organizations

@HotDrink
thejohnfreeman commented on pull request thejohnfreeman/autocheck#9
@thejohnfreeman

To be clear, you might need to expand tabs in the other edits; I'm not going to tag each one.

thejohnfreeman commented on pull request thejohnfreeman/autocheck#9
@thejohnfreeman

Put brace on same line as TEST macro.

thejohnfreeman commented on pull request thejohnfreeman/autocheck#9
@thejohnfreeman

No tabs please. Spaces only. Ok to put colon and initializer list on same line.

@thejohnfreeman
Remove spurious files
2 commits with 0 additions and 0 deletions
@thejohnfreeman
@thejohnfreeman

This doesn't seem to match the surrounding style, which has no whitespace between if and the opening parenthesis, and a single space between the cl…

@thejohnfreeman

This block could just be hasForm = !isSingle.

thejohnfreeman commented on issue esvit/ng-table#399
@thejohnfreeman

No comment? This doesn't appear addressed.

thejohnfreeman commented on issue sampsyo/confit#7
@thejohnfreeman

I think we can certainly add that type of projection, should be easy. I'll think more about nesting regardless.

thejohnfreeman commented on pull request sampsyo/confit#16
@thejohnfreeman

I'd rather work in my fork and let you pull things in as you like. I've started work on the implementation, I think I can have a prototype in a few…

thejohnfreeman commented on pull request sampsyo/confit#16
@thejohnfreeman

Yeah, how about as_default_type?

thejohnfreeman commented on issue sampsyo/confit#7
@thejohnfreeman

That's where I imagined we'd use scoping string-encoded in the variable names: server.host = example.com server.port = 80 In my first draft, you'l…

thejohnfreeman commented on pull request sampsyo/confit#16
@thejohnfreeman

Should this work as a "cast" too, on a per-variable basis? What do you mean?

thejohnfreeman commented on pull request sampsyo/confit#16
@thejohnfreeman

We can certainly add the AttrDict functionality to every configuration type so the convenient syntax is available everywhere. Using casts for proje…

thejohnfreeman commented on pull request sampsyo/confit#16
@thejohnfreeman

You're right, let's go with that.

thejohnfreeman commented on pull request sampsyo/confit#16
@thejohnfreeman

Exactly.

thejohnfreeman commented on pull request sampsyo/confit#16
@thejohnfreeman

+1

thejohnfreeman commented on pull request sampsyo/confit#16
@thejohnfreeman

Exactly. I think we can easily throw in something that works for 80% of argparse users.

thejohnfreeman commented on pull request sampsyo/confit#16
@thejohnfreeman

stack() will be part of the general Variable interface. The flat variable class will have a trivial implementation, return [self]. Also, it will ne…

thejohnfreeman commented on pull request sampsyo/confit#16
@thejohnfreeman

Indeed. We even chose the same names.

thejohnfreeman commented on pull request sampsyo/confit#16
@thejohnfreeman

Definitely going to have to reorganize the document to help with things like this.

thejohnfreeman commented on pull request sampsyo/confit#16
@thejohnfreeman

I agree with integrating with existing command line parsers. Let's add a from_object(obj, prefix='') source for that. The prefix can be used to sel…

thejohnfreeman commented on pull request sampsyo/confit#16
@thejohnfreeman

Absolutely.

thejohnfreeman commented on pull request sampsyo/confit#16
@thejohnfreeman

I'm cool with that. Maybe we can include a function to register a standard pretty printing exception hook for the convenience of users who want it?

thejohnfreeman commented on pull request sampsyo/confit#16
@thejohnfreeman

This is just what I'm proposing for the behavior of uncaught exceptions; the default now is for Python to print a full stack trace. Callers can sti…

thejohnfreeman commented on pull request sampsyo/confit#16
@thejohnfreeman

You probably haven't got to this point in the doc yet, but I'm hoping to address that with the flatten function (whose description I just updated):

@thejohnfreeman
thejohnfreeman commented on pull request sampsyo/confit#16
@thejohnfreeman

It's pretty fuzzy, and I think we can really improve the language here. Maybe: A configuration can be packaged and imported, but data cannot. Unli…

thejohnfreeman opened pull request sampsyo/confit#16
@thejohnfreeman
doc: proposed design
2 commits with 404 additions and 266 deletions