Skip to content

Tags: theketchio/ketch

Tags

v0.7.0

Toggle v0.7.0's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Ketch can't deploy new apps after failure

When an invalid field is set in the App CR like so (it can be any invalid field):

```
      volumes:
      - name: aaa/bbb
        persistentVolumeClaim:
          claimName: aaa/bbb
```

The following kubernetes event will get emitted:

```
failed to get deploy events: create Pod bulletinboard-web-1-0 in StatefulSet bulletinboard-web-1 failed error: Pod "bulletinboard-web-1-0" is invalid: spec.volumes[0].name: Invalid value: "aaa/bbb": a lowercase RFC 1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name',  or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?')
```

Due to this, the following for loop will never break as the ObservedGeneration will never increase from 0 due to the invalid field, only until 10 minutes has elapsed with the ctx:
ketch/app_controller.go at c6aa420 · theketchio/ketch

Additional logic within wl, err = cli.Get(ctx) to check the event associated with the workload and return the error on a specific condition (e.Type == "Warning" && e.Reason == "FailedCreate") was added

v0.7.0-rc-2

Toggle v0.7.0-rc-2's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Ketch can't deploy new apps after failure

When an invalid field is set in the App CR like so (it can be any invalid field):

```
      volumes:
      - name: aaa/bbb
        persistentVolumeClaim:
          claimName: aaa/bbb
```

The following kubernetes event will get emitted:

```
failed to get deploy events: create Pod bulletinboard-web-1-0 in StatefulSet bulletinboard-web-1 failed error: Pod "bulletinboard-web-1-0" is invalid: spec.volumes[0].name: Invalid value: "aaa/bbb": a lowercase RFC 1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name',  or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?')
```

Due to this, the following for loop will never break as the ObservedGeneration will never increase from 0 due to the invalid field, only until 10 minutes has elapsed with the ctx:
ketch/app_controller.go at c6aa420 · theketchio/ketch

Additional logic within wl, err = cli.Get(ctx) to check the event associated with the workload and return the error on a specific condition (e.Type == "Warning" && e.Reason == "FailedCreate") was added

0.7.0-rc-1

Toggle 0.7.0-rc-1's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
[shipa-2799] - Starting process via Ketch CLI outputs "Successfully s…

…tarted!" when passing invalid process name (#254)

When passing invalid process name to app stop, correct output is shown (process not found) When passing invalid process name to app start the app does not start as expected, but the output shows “Successfully started!”

v0.7.0-rc-1

Toggle v0.7.0-rc-1's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
[shipa-2799] - Starting process via Ketch CLI outputs "Successfully s…

…tarted!" when passing invalid process name (#254)

When passing invalid process name to app stop, correct output is shown (process not found) When passing invalid process name to app start the app does not start as expected, but the output shows “Successfully started!”

v0.6.2

Toggle v0.6.2's commit message
0.6.2 release

v0.6.2-rc-1

Toggle v0.6.2-rc-1's commit message
performance upgrades

v0.6.1

Toggle v0.6.1's commit message
0.6.1

v0.6.1-rc-1

Toggle v0.6.1-rc-1's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
[SHIPA-2118] Gracefull handle cert-manager boot (#193)

This commit makes webhook-server-cert secret optional, if it is not
ready, ketch's pod gets restarted.

v0.6.0

Toggle v0.6.0's commit message
release 0.6.0

v0.6.0-rc-1

Toggle v0.6.0-rc-1's commit message
canary event annotations; prune dead apps; pod status with group; eve…

…nts printing fixes; user service accounts; https redirect