use the last version of ruby-progressbar gem #31

Closed
wants to merge 1 commit into from

3 participants

@DarthSim

Old verisons of ruby-progressbar occur SystemStackError in some cases

@jeffkreeftmeijer

Hey Sergey,

Could you explain how I can reproduce this so I can work on a regression test for it?

Thanks for helping out!

-- Jeff

@DarthSim

Hi Jeff,

It's very difficult to reproduce error because it depends on terminal width. In some cases calculation of bar width may fall into infinite loop. I fixed this error and author of ruby-progressbar commited my pull request.

I had a headache when I tried to understand why my empty tests fail.

As I have noticed just now, jfelchner didn't push updated code to rubygems.org, so this pull request makes no sence. He develops new version of ruby-progressbar, it may be good to use it.

Sergey

@jeffkreeftmeijer

I just released 1.1.0.rc1, which uses ruby-progressbar 1.0.0.rc1. Could you try that and let me know if that solves your problem? :)

@DarthSim

Yep it does, thank you!
Just a note: version from rubygems.org still uses old ruby-progressbar v0.0.10

@jeffkreeftmeijer
@jfelchner

@jeffkreeftmeijer this can be closed.

@jfelchner jfelchner closed this May 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment