Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the last version of ruby-progressbar gem #31

Closed
wants to merge 1 commit into from
Closed

use the last version of ruby-progressbar gem #31

wants to merge 1 commit into from

Conversation

@DarthSim
Copy link

@DarthSim DarthSim commented Aug 3, 2012

Old verisons of ruby-progressbar occur SystemStackError in some cases

@jeffkreeftmeijer
Copy link
Contributor

@jeffkreeftmeijer jeffkreeftmeijer commented Aug 5, 2012

Hey Sergey,

Could you explain how I can reproduce this so I can work on a regression test for it?

Thanks for helping out!

-- Jeff

@DarthSim
Copy link
Author

@DarthSim DarthSim commented Aug 5, 2012

Hi Jeff,

It's very difficult to reproduce error because it depends on terminal width. In some cases calculation of bar width may fall into infinite loop. I fixed this error and author of ruby-progressbar commited my pull request.

I had a headache when I tried to understand why my empty tests fail.

As I have noticed just now, jfelchner didn't push updated code to rubygems.org, so this pull request makes no sence. He develops new version of ruby-progressbar, it may be good to use it.

Sergey

@jeffkreeftmeijer
Copy link
Contributor

@jeffkreeftmeijer jeffkreeftmeijer commented Aug 14, 2012

I just released 1.1.0.rc1, which uses ruby-progressbar 1.0.0.rc1. Could you try that and let me know if that solves your problem? :)

@DarthSim
Copy link
Author

@DarthSim DarthSim commented Aug 14, 2012

Yep it does, thank you!
Just a note: version from rubygems.org still uses old ruby-progressbar v0.0.10

@jeffkreeftmeijer
Copy link
Contributor

@jeffkreeftmeijer jeffkreeftmeijer commented Aug 14, 2012

Hey Sergey,

Thanks for letting me know. However, the rc (https://rubygems.org/gems/fuubar/versions/1.1.0.rc1) actually uses the correct version, but the gem page (https://rubygems.org/gems/fuubar) still shows fuubar 1.0.0, as the rc is a prerelease. :)

On Aug 15, 2012, at 12:15 AM, Sergey Alexandrovich notifications@github.com wrote:

Yep it does, thank you!
Just a note: version from rubygems.org still uses old ruby-progressbar v0.0.10


Reply to this email directly or view it on GitHub.

@jfelchner
Copy link
Collaborator

@jfelchner jfelchner commented May 30, 2013

@jeffkreeftmeijer this can be closed.

@jfelchner jfelchner closed this May 30, 2013
@github-actions
Copy link

@github-actions github-actions bot commented Dec 28, 2020

This issue has been closed automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants