Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for ruby-progressbar v1.0 #32

Merged
merged 11 commits into from Aug 14, 2012
Merged

Update for ruby-progressbar v1.0 #32

merged 11 commits into from Aug 14, 2012

Conversation

@jfelchner
Copy link
Collaborator

@jfelchner jfelchner commented Aug 4, 2012

Here are the necessary changes to get Fuubar working with the upcoming ruby-progressbar v1.0 release. I put out a gem as 1.0.0rc1 so you should be able to test it out and see if it will work for you.

I took a couple liberties with formatting to take advantage of the new features in v1.0 and you may not agree with them so adjust to taste. :)

The bar in this PR will output something like:

10/100 |====== 20 ======>                                         |  ETA: 10:10:10

I also removed quite a few specs due to the fact that they were now testing across boundaries. You may not agree with that either so just let me know if you want me to revert any of the changes.

Let me know if you have any questions.

@jfelchner
Copy link
Collaborator Author

@jfelchner jfelchner commented Aug 4, 2012

I also wanted to mention that I am going to keep strictly to SemVer with this gem, so you can safely put ~> 1.0 in your gemspec when we're ready for a final release.

@nofxx
Copy link

@nofxx nofxx commented Aug 13, 2012

Waiting for this =D

@jeffkreeftmeijer jeffkreeftmeijer merged commit 4984fd5 into thekompanee:develop Aug 14, 2012
@jeffkreeftmeijer
Copy link
Contributor

@jeffkreeftmeijer jeffkreeftmeijer commented Aug 14, 2012

I released 1.1.0.rc1, it'd be great if you guys could take it for a spin and let me know if everything still works for you.

Thanks a lot for your work, @jfelchner! :)

@jfelchner
Copy link
Collaborator Author

@jfelchner jfelchner commented Aug 22, 2012

Seems to be working for me thus far. I went ahead and released ruby-progressbar 1.0.0 final. Feel free to update at your leisure. :)

@jeffkreeftmeijer
Copy link
Contributor

@jeffkreeftmeijer jeffkreeftmeijer commented Sep 27, 2012

I just released 1.1.0 (https://rubygems.org/gems/fuubar/versions/1.1.0), which uses ruby-progressbar 1.0.0. Thanks again! :)

@nofxx
Copy link

@nofxx nofxx commented Sep 27, 2012

Thank you! Progressbar is on our stack in all projects.

On Sep 27, 2012, at 4:41 AM, Jeff Kreeftmeijer wrote:

I just released 1.1.0 (https://rubygems.org/gems/fuubar/versions/1.1.0), which uses ruby-progressbar 1.0.0. Thanks again! :)


Reply to this email directly or view it on GitHub.

@github-actions
Copy link

@github-actions github-actions bot commented Dec 28, 2020

This issue has been closed automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants