Remove instafail dependency #33

Closed
wants to merge 14 commits into
from

Projects

None yet

1 participant

@jfelchner
Collaborator

@jeffkreeftmeijer I saw this referenced in issues #29 and #20 so I thought I'd give you a bonus. :)

I didn't do any extensive testing and I did leave the specs in a failing state (for shame!). I basically just wanted to see if I could get it to work.

Everything appears to work just as if instafail was installed although I didn't do extensive testing. I just thought I'd put this out there.

Also, this is based on update-ruby-progressbar-to-v1 so I'd either cherry pick these commits or merge that branch in first.

@jfelchner jfelchner added a commit that referenced this pull request Dec 15, 2013
@jfelchner jfelchner Merge branch 'feature/remove-rspec-instafail' into develop - Closes #36
…, #29, #20, #33

* feature/remove-rspec-instafail:
  Big refactoring to use the capabilities exposed by RSpec's formatters as well as replacing the specs with ones which are more representative
  Add .ruby-version file
  Use RSpec's helpers to output the failures at the proper time
  Remove all references to instafail
  Remove rspec-instafail from the project
14a7d93
@jfelchner jfelchner closed this Dec 15, 2013
@jfelchner jfelchner added a commit that referenced this pull request Apr 24, 2016
@jfelchner jfelchner Merge branch 'feature/remove-rspec-instafail' into develop - Closes #36
…, #29, #20, #33

* feature/remove-rspec-instafail:
  Big refactoring to use the capabilities exposed by RSpec's formatters as well as replacing the specs with ones which are more representative
  Add .ruby-version file
  Use RSpec's helpers to output the failures at the proper time
  Remove all references to instafail
  Remove rspec-instafail from the project
edcc916
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment