Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print color end esc seq only when colors enabled #34

Conversation

@hron
Copy link
Contributor

@hron hron commented Aug 5, 2012

Printing "\e[0m" is not a problem for major terminal emulators, but not for Emacs' dump terminal... Progress bar is just not shown when fuubar works inside Emacs' terminal, even when colors are disabled.

With this patch a user is able to disable colors and have progress bar displayed in Emacs.

hron added 3 commits Dec 29, 2011
Printing "\e[0m" is not a problem for major terminal emulators, but
not for Emacs' dump terminal... Progress bar is just not shown when
fuubar works inside Emacs' terminal, even when colors are disabled.

With this patch a user is able to disable colors and have progress bar
displayed in Emacs.
This reverts commit e0f7ca0.
@hron
Copy link
Contributor Author

@hron hron commented Aug 5, 2012

Ooops. Sorry for the guard commit. ;)

@jeffkreeftmeijer
Copy link
Contributor

@jeffkreeftmeijer jeffkreeftmeijer commented Aug 6, 2012

Hey Aleksei,

Thanks for helping out! Could you take out the two Guard-commits (e0f7ca0 and 6769091) and add a test to make sure I won't break this in a future release?

Thanks again!

-- Jeff

@jfelchner
Copy link
Collaborator

@jfelchner jfelchner commented Aug 16, 2013

@hron added here: 6c93377

Thanks!

@jfelchner jfelchner closed this Aug 16, 2013
@github-actions
Copy link

@github-actions github-actions bot commented Dec 28, 2020

This issue has been closed automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants