New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print color end esc seq only when colors enabled #34

Closed
wants to merge 3 commits into
base: develop
from

Conversation

Projects
None yet
3 participants
@hron
Copy link
Contributor

hron commented Aug 5, 2012

Printing "\e[0m" is not a problem for major terminal emulators, but not for Emacs' dump terminal... Progress bar is just not shown when fuubar works inside Emacs' terminal, even when colors are disabled.

With this patch a user is able to disable colors and have progress bar displayed in Emacs.

hron added some commits Dec 29, 2011

Print end color escape sequence only when colors are enabled.
Printing "\e[0m" is not a problem for major terminal emulators, but
not for Emacs' dump terminal... Progress bar is just not shown when
fuubar works inside Emacs' terminal, even when colors are disabled.

With this patch a user is able to disable colors and have progress bar
displayed in Emacs.
Revert "added guard."
This reverts commit e0f7ca0.
@hron

This comment has been minimized.

Copy link
Contributor

hron commented Aug 5, 2012

Ooops. Sorry for the guard commit. ;)

@jeffkreeftmeijer

This comment has been minimized.

Copy link
Contributor

jeffkreeftmeijer commented Aug 6, 2012

Hey Aleksei,

Thanks for helping out! Could you take out the two Guard-commits (e0f7ca0 and 6769091) and add a test to make sure I won't break this in a future release?

Thanks again!

-- Jeff

@jfelchner

This comment has been minimized.

Copy link
Collaborator

jfelchner commented Aug 16, 2013

@hron added here: 6c93377

Thanks!

@jfelchner jfelchner closed this Aug 16, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment