Convert timestamps to long's #4

Merged
merged 2 commits into from Feb 3, 2014

Conversation

Projects
None yet
2 participants
@amorton

amorton commented Feb 3, 2014

not all timestamps are from this century, those from before the year 2000 have
less digits. Comparing the bytes only is wrong in this case.

@zznate please look at this first thing Monday morning.

amorton added some commits Feb 3, 2014

Convert timestamps to long's
not all timestamps are from this century, those from before
the year 2000 have less digits. Comparing the bytes only
is wrong in this case.
@zznate

This comment has been minimized.

Show comment Hide comment
@zznate

zznate Feb 3, 2014

@amorton with the use of Long.compare, this is now bound to JDK7. Is this correct?

zznate commented Feb 3, 2014

@amorton with the use of Long.compare, this is now bound to JDK7. Is this correct?

@amorton

This comment has been minimized.

Show comment Hide comment
@amorton

amorton Feb 3, 2014

did not notice it was 1.7 only, but yet we are using 1.7 in prod and 1.6 is EOL so I feel that is OK.

Will merge with this in place.

amorton commented Feb 3, 2014

did not notice it was 1.7 only, but yet we are using 1.7 in prod and 1.6 is EOL so I feel that is OK.

Will merge with this in place.

amorton added a commit that referenced this pull request Feb 3, 2014

@amorton amorton merged commit dd8d577 into master Feb 3, 2014

@amorton amorton deleted the zero-copy-TLP branch Feb 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment