Skip to content

Missing deps on test sections? #27

Closed
pveber opened this Issue Jan 3, 2012 · 6 comments

3 participants

@pveber
pveber commented Jan 3, 2012

Hi,
starting from a fresh install, I fail to install oasis:

philippe@robby:~$ echo $OCAMLPATH
/home/philippe/.odb/lib
philippe@robby:~$ rm -rf ./.odb
philippe@robby:~$ ocaml odb.ml oasis
Installing oasis
Installing odn
Installing type-conv
Deps for type-conv satisfied
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 50638  100 50638    0     0   114k      0 --:--:-- --:--:-- --:--:--  114k
type-conv-3.0.4/.hg_archival.txt
[SNIP]
Installed /home/philippe/.odb/lib/type-conv/META
Successfully installed type-conv
Deps for odn satisfied
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 57339  100 57339    0     0  64935      0 --:--:-- --:--:-- --:--:--   98k
ocaml-data-notation-0.0.7/
ocaml-data-notation-0.0.7/tests/
ocaml-data-notation-0.0.7/tests/TestConf.ml.ab
ocaml-data-notation-0.0.7/tests/test.ml
ocaml-data-notation-0.0.7/tests/data/
ocaml-data-notation-0.0.7/tests/data/variant.ml
ocaml-data-notation-0.0.7/tests/data/oasis-examples/
ocaml-data-notation-0.0.7/tests/data/oasis-examples/OASISTypes.ml
ocaml-data-notation-0.0.7/tests/data/oasis-examples/main.ml
ocaml-data-notation-0.0.7/tests/data/oasis-examples/PropList.ml
ocaml-data-notation-0.0.7/tests/data/tuples.ml
ocaml-data-notation-0.0.7/tests/data/polyvariants.ml
ocaml-data-notation-0.0.7/tests/TestCommon.ml
ocaml-data-notation-0.0.7/src/
ocaml-data-notation-0.0.7/src/pa_noodn.ml
ocaml-data-notation-0.0.7/src/odn.odocl
ocaml-data-notation-0.0.7/src/pa_odn.mllib
ocaml-data-notation-0.0.7/src/pa_noodn.mllib
ocaml-data-notation-0.0.7/src/odn.mllib
ocaml-data-notation-0.0.7/src/META
ocaml-data-notation-0.0.7/src/pa_odn.ml
ocaml-data-notation-0.0.7/src/ODN.ml
ocaml-data-notation-0.0.7/CHANGES.txt
ocaml-data-notation-0.0.7/AUTHORS.txt
ocaml-data-notation-0.0.7/setup.ml
ocaml-data-notation-0.0.7/Makefile
ocaml-data-notation-0.0.7/README.txt
ocaml-data-notation-0.0.7/_header
ocaml-data-notation-0.0.7/_headache.config
ocaml-data-notation-0.0.7/INSTALL.txt
ocaml-data-notation-0.0.7/COPYING.txt
ocaml-data-notation-0.0.7/configure
ocaml-data-notation-0.0.7/_tags
ocaml-data-notation-0.0.7/.boring
ocaml-data-notation-0.0.7/myocamlbuild.ml
ocaml-data-notation-0.0.7/_oasis
I: Running command '/home/philippe/usr/godi/bin/ocamlc.opt -config > '/tmp/oasis-f83b31.txt''
I: Running command '/home/philippe/usr/godi/bin/ocamlfind query -format %v findlib > '/tmp/oasis-d4a71c.txt''
I: Running command '/home/philippe/usr/godi/bin/ocamlfind query -format %d type-conv > '/tmp/oasis-7810b4.txt''
I: Running command '/home/philippe/usr/godi/bin/ocamlfind query -format %d camlp4.lib > '/tmp/oasis-76b18b.txt''
I: Running command '/home/philippe/usr/godi/bin/ocamlfind query -format %d camlp4.quotations.o > '/tmp/oasis-876ddc.txt''
I: Running command '/home/philippe/usr/godi/bin/ocamlfind query -format %d type-conv > '/tmp/oasis-d11b4b.txt''
I: Running command '/home/philippe/usr/godi/bin/ocamlfind query -format %d type-conv > '/tmp/oasis-dca1ad.txt''
I: Running command '/home/philippe/usr/godi/bin/ocamlfind query -format %v type-conv > '/tmp/oasis-a8b1f6.txt''
I: Running command '/home/philippe/usr/godi/bin/ocamlfind query -format %d camlp4.lib > '/tmp/oasis-c3858f.txt''
I: Running command '/home/philippe/usr/godi/bin/ocamlfind query -format %d camlp4.lib > '/tmp/oasis-74d3b2.txt''
I: Running command '/home/philippe/usr/godi/bin/ocamlfind query -format %d camlp4.quotations.o > '/tmp/oasis-ba71b8.txt''
I: Running command '/home/philippe/usr/godi/bin/ocamlfind query -format %d camlp4.quotations.o > '/tmp/oasis-99f95f.txt''
I: Running command '/home/philippe/usr/godi/bin/ocamlfind query -format %d oUnit > '/tmp/oasis-f3fae8.txt''
ocamlfind: Package `oUnit' not found
W: Field 'pkg_ounit' is not set: Command '/home/philippe/usr/godi/bin/ocamlfind query -format %d oUnit > '/tmp/oasis-f3fae8.txt'' terminated with error code 2
I: Running command '/home/philippe/usr/godi/bin/ocamlfind query -format %d fileutils > '/tmp/oasis-737a7d.txt''
ocamlfind: Package `fileutils' not found
W: Field 'pkg_fileutils' is not set: Command '/home/philippe/usr/godi/bin/ocamlfind query -format %d fileutils > '/tmp/oasis-737a7d.txt'' terminated with error code 2
I: Running command '/home/philippe/usr/godi/bin/ocamlfind query -format %d str > '/tmp/oasis-785e2b.txt''
E: Cannot find findlib package fileutils (>= 0.4.0)
E: Cannot find findlib package oUnit (>= 1.1.0)
E: Failure("2 configuration errors")
Exception: Failure "Could not configure odn".

It seems that odb do not add deps from the test section (fileutils and oUnit), while the configure script of odn requires them. This issue is related to #25, in that there is a need to access test dependencies with oasis-db.

Easy workaround of course, first install the missing dependencies, by invoking ocaml odb.ml fileutils directly. I'm posting it here for the record (hope I'm not duplicating a previous bug report ...)

@thelema
Owner
thelema commented Jan 3, 2012

Sadly, this is a known and undocumented problem. The problem is just in the ocaml-data-notation package. Gildor patched 0.0.6 quickly, and must have used his development version of oasis to generate its setup.ml file. This file tries to configure dependencies needed for testing, and fails because it can't find them. Oasis-db only lists as dependencies those packages needed to build and install, not to test. There's two solutions, the short-term fix-odn solution and the long term fix-oasis-db solution. I'm trying for the long term solution, but need gildor's help.

@thelema thelema was assigned Jan 3, 2012
@pveber
pveber commented Jan 5, 2012

To be honest, I think it is better in every way to fix odn: a package shouldn't be released in setup-dev mode. Maybe I can simply reupload a fixed odn on oasis-db?

@gildor478

The package had been released in setup-dev mode. It seems there is a bug with deps computation when there is a flag involved. Consider filling a bug to remind me to solve this.

@pveber
pveber commented Jan 6, 2012

Thanks for commenting on this Sylvain. If I understand you right, the lib part of oasis, which is used to compute dependencies, is at fault here. That would mean that the REST API needs no change, it should just provide enough dependencies for the package to compile, even if the package is in setup-dev mode, right?. Anyway I'll gladly report this on the bug tracker of oasis.

@gildor478

OK, I totally mismatch my sentence. "The package had NOT been released in setup-dev mode". The rest of the comment stands. There is a bug in dependency calculation with flags. Please fill a bug against oasis. The quick solution is to have "Default: false" for flag Test in odn.

@pveber
pveber commented Jan 6, 2012

Bug reported, thanks!

@thelema thelema closed this Mar 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.