Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to 2.3.1 #9

Merged
merged 2 commits into from May 3, 2017
Merged

upgrade to 2.3.1 #9

merged 2 commits into from May 3, 2017

Conversation

fogmann
Copy link

@fogmann fogmann commented May 2, 2017

@angular/core: 2.3.1
rxjs: 5.0.0-rc.4
@angular/cli: 1.0.1

move app.module

    @angular/core: 2.3.1
    rxjs: 5.0.0-rc.4
    @angular/cli: 1.0.1

move app.module
@fogmann
Copy link
Author

fogmann commented May 2, 2017

Trying to get rxjs-socket.io to work in my project and it is not up-to-date.
Updated the files to make it current.

@thelgevold
Copy link
Owner

Thanks!
I was thinking it would make sense to update these dependencies to the latest versions. Angular 4.1 etc.

CLI is no longer in Beta, so it would be nice to bring that up to the latest as well.

set templateUrl for chat component
{{message.text}}
</div>
<input [(ngModel)]="message" /><button (click)="sendMessage()">Send</button>`,
templateUrl: './chat.component.html',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the html file missing? Can't see it in the diff?

@fogmann
Copy link
Author

fogmann commented May 3, 2017

It is already there, but wasn't linked.

@thelgevold thelgevold merged commit 64750b9 into thelgevold:master May 3, 2017
@thelgevold
Copy link
Owner

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants