New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fieldVars param in renderFormCollectionField smarty block #1613

Merged
merged 1 commit into from Aug 6, 2015

Conversation

Projects
None yet
4 participants
@Alban-io
Contributor

Alban-io commented Aug 4, 2015

Currently in the Form::renderFormCollectionField() method the assignFieldValues $fieldVars param is the FormConfigBuilder options attribute.

I replace it with the current FormView field vars like in Form::processFormField() because the FormConfigBuilder options doesn't contains the Form error.

@lunika

This comment has been minimized.

Show comment
Hide comment
@lunika

lunika Aug 4, 2015

Contributor

Contributor

lunika commented Aug 4, 2015

@lovenunu

This comment has been minimized.

Show comment
Hide comment
@lovenunu

lovenunu Aug 4, 2015

Contributor

wow

Contributor

lovenunu commented Aug 4, 2015

wow

@Alban-io

This comment has been minimized.

Show comment
Hide comment
@Alban-io

Alban-io Aug 4, 2015

Contributor

😕 ?

Contributor

Alban-io commented Aug 4, 2015

😕 ?

bibich added a commit that referenced this pull request Aug 6, 2015

Merge pull request #1613 from Alban-io/fix-smarty-block-render-form-c…
…ollection-field

Fix fieldVars param in renderFormCollectionField smarty block

@bibich bibich merged commit b07e6ee into thelia:master Aug 6, 2015

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bibich

This comment has been minimized.

Show comment
Hide comment
@bibich

bibich Aug 6, 2015

Contributor

faleminderit

Contributor

bibich commented Aug 6, 2015

faleminderit

@Alban-io Alban-io deleted the Alban-io:fix-smarty-block-render-form-collection-field branch Dec 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment