New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product attributes select size is now limited. #1668

Merged
merged 1 commit into from Sep 23, 2015

Conversation

Projects
None yet
2 participants
@roadster31
Contributor

roadster31 commented Sep 7, 2015

In the Attributes & Features tab of the product , the select size for an attribute is set to the number of attributes values (aka attribute availability). This is a problem when an attribute has many values.

This PR limits the number of options to maximum_product_attribute_select_size, a value defined in the variables.conf file of the default BO template.

The current value is 10.

gillesbourgeat added a commit that referenced this pull request Sep 23, 2015

Merge pull request #1668 from roadster31/attribute-select-size
Product attributes select size is now limited.

@gillesbourgeat gillesbourgeat merged commit b13d7f9 into thelia:master Sep 23, 2015

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gillesbourgeat gillesbourgeat added this to the 2.3.0-alpha1 milestone Nov 19, 2015

@roadster31 roadster31 deleted the roadster31:attribute-select-size branch Nov 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment