New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order::createOrder() improvement to allow order duplication. #1701

Merged
merged 5 commits into from Jan 4, 2016

Conversation

Projects
None yet
2 participants
@roadster31
Contributor

roadster31 commented Sep 24, 2015

This PR improves the Order::createOrder() so that the method could be used to duplicate an order by re-using the delivery and invoice addresses defined in the original order.

The $useOrderDefinedAddresses parameter has been added to select the required behaviour. If true, the order addresses are re-used. If false, the getChoosen_XXXX_Address() methods are used to get the customer addresses choice, and new OrderAdresses are created.

@bibich

This comment has been minimized.

Show comment
Hide comment
@bibich

bibich Oct 7, 2015

Contributor

Thanks.
It would be great to update unit tests.
In fact, there is not yet tests for createManual action, so could you implement some ?

Contributor

bibich commented Oct 7, 2015

Thanks.
It would be great to update unit tests.
In fact, there is not yet tests for createManual action, so could you implement some ?

@roadster31

This comment has been minimized.

Show comment
Hide comment
@roadster31

roadster31 Oct 14, 2015

Contributor

I'd like to add test for createManual action, but have no time for this at the moment.

Contributor

roadster31 commented Oct 14, 2015

I'd like to add test for createManual action, but have no time for this at the moment.

@roadster31

This comment has been minimized.

Show comment
Hide comment
@roadster31

roadster31 Nov 23, 2015

Contributor

Is something missing to this PR (apart unit tests) ?

Contributor

roadster31 commented Nov 23, 2015

Is something missing to this PR (apart unit tests) ?

@roadster31

This comment has been minimized.

Show comment
Hide comment
@roadster31

roadster31 Dec 31, 2015

Contributor

The PR is now complete.

Contributor

roadster31 commented Dec 31, 2015

The PR is now complete.

bibich added a commit that referenced this pull request Jan 4, 2016

Merge pull request #1701 from roadster31/order-creation-fix
Order::createOrder() improvement to allow order duplication.

@bibich bibich merged commit 7822fca into thelia:master Jan 4, 2016

2 checks passed

Scrutinizer 1 new issues, 2 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bibich

This comment has been minimized.

Show comment
Hide comment
@bibich

bibich Jan 4, 2016

Contributor

Thanks

Contributor

bibich commented Jan 4, 2016

Thanks

@roadster31 roadster31 deleted the roadster31:order-creation-fix branch Jan 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment