New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced parameter "locale" with "lang" in generated URL #1722

Merged
merged 1 commit into from Oct 16, 2015

Conversation

Projects
None yet
3 participants
@bibich
Contributor

bibich commented Oct 8, 2015

The locale parameter in generated URLs of products, categories, ... is ambiguous with the lang parameter. And changing the locale in URL does not change the lang of the displayed content.

As the pages are indexed with the parameter 'locale' and not 'lang' by search engines there is potentialy a problem. In fact, it only happens when the rewriting is disabled on your website, which is rather uncommon.

I 'm not sure that there won't be side effects with this PR. Will you please look it over ?

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat
Member

gillesbourgeat commented Oct 16, 2015

👍

gillesbourgeat added a commit that referenced this pull request Oct 16, 2015

Merge pull request #1722 from bibich/fixes
Replaced parameter "locale" with "lang" in generated URL

@gillesbourgeat gillesbourgeat merged commit c15439f into thelia:master Oct 16, 2015

2 checks passed

Scrutinizer 2 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

This was referenced Oct 16, 2015

@gillesbourgeat gillesbourgeat added this to the 2.3.0-alpha1 milestone Nov 19, 2015

@bibich bibich referenced this pull request Jan 11, 2016

Closed

Sitemap : Invalid XML #1710

@bibich bibich deleted the bibich:fixes branch Feb 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment