New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix critical performance issue on ProductController HydrateObjectForm #1734

Merged
merged 1 commit into from Oct 14, 2015

Conversation

Projects
None yet
5 participants
@Soldras
Contributor

Soldras commented Oct 14, 2015

Clean foreach to not create forms each time ...

@roadster31

This comment has been minimized.

Show comment
Hide comment
@roadster31

roadster31 Oct 14, 2015

Contributor

Nice catch 👍

Contributor

roadster31 commented Oct 14, 2015

Nice catch 👍

@Alban-io

This comment has been minimized.

Show comment
Hide comment
@Alban-io

Alban-io Oct 14, 2015

Contributor

👍

Contributor

Alban-io commented Oct 14, 2015

👍

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat
Member

gillesbourgeat commented Oct 14, 2015

👍

@bcbrr

This comment has been minimized.

Show comment
Hide comment
@bcbrr

bcbrr Oct 14, 2015

Contributor

👍

Contributor

bcbrr commented Oct 14, 2015

👍

gillesbourgeat added a commit that referenced this pull request Oct 14, 2015

Merge pull request #1734 from Soldras/critical-performance-issue
Fix critical performance issue on ProductController HydrateObjectForm

@gillesbourgeat gillesbourgeat merged commit 7b48ac5 into thelia:master Oct 14, 2015

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bibich bibich referenced this pull request Oct 16, 2015

Merged

Version 2.2.1 #1736

bibich added a commit to bibich/thelia that referenced this pull request Oct 19, 2015

@bibich bibich referenced this pull request Oct 19, 2015

Merged

Version 2.1.7 #1737

bibich added a commit to bibich/thelia that referenced this pull request Oct 19, 2015

@bibich bibich referenced this pull request Oct 19, 2015

Merged

Version 2.0.11 #1738

@gillesbourgeat gillesbourgeat added this to the 2.3.0-alpha1 milestone Nov 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment