New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output value IS_DEFAULT in the product_sale_elements loop #1745

Merged
merged 2 commits into from Nov 5, 2015

Conversation

Projects
None yet
2 participants
@gillesbourgeat
Member

gillesbourgeat commented Oct 22, 2015

In the propel schema, the is_default column for the product_sale_elements table, is boolean type.

<table name="product_sale_elements" namespace="Thelia\Model">
    <column autoIncrement="true" name="id" primaryKey="true" required="true" type="INTEGER" />
    <column name="product_id" required="true" type="INTEGER" />
    <column name="ref" required="true" size="255" type="VARCHAR" />
    <column name="quantity" required="true" type="FLOAT" />
    <column defaultValue="0" name="promo" type="TINYINT" />
    <column defaultValue="0" name="newness" type="TINYINT" />
    <column defaultValue="0" name="weight" type="FLOAT" />
    <column defaultValue="0" name="is_default" type="BOOLEAN" />
...
@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Nov 4, 2015

Member

Why not. Done

Member

gillesbourgeat commented Nov 4, 2015

Why not. Done

bibich added a commit that referenced this pull request Nov 5, 2015

Merge pull request #1745 from gillesbourgeat/pse_default
Fix output value IS_DEFAULT in the product_sale_elements loop

@bibich bibich merged commit 2a3ece1 into thelia:master Nov 5, 2015

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gillesbourgeat gillesbourgeat added this to the 2.3.0-alpha1 milestone Nov 19, 2015

@gillesbourgeat gillesbourgeat deleted the gillesbourgeat:pse_default branch Dec 28, 2015

gillesbourgeat added a commit to gillesbourgeat/thelia that referenced this pull request Jan 6, 2016

gillesbourgeat added a commit to gillesbourgeat/thelia that referenced this pull request Jan 6, 2016

gillesbourgeat added a commit to gillesbourgeat/thelia that referenced this pull request Jan 6, 2016

gillesbourgeat added a commit to gillesbourgeat/thelia that referenced this pull request Jan 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment