New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EQUAL to product loop filter by min or max #1750

Merged
merged 1 commit into from Oct 27, 2015

Conversation

Projects
None yet
2 participants
@lopes-vincent
Contributor

lopes-vincent commented Oct 27, 2015

In product loop :

Change min_stock Criteria::GREATER_THAN to GREATER_EQUAL

Change min_weight Criteria::GREATER_THAN to GREATER_EQUAL
Change max_weight Criteria::LESS_THAN to LESS_EQUAL

Because if we set min_stock to 1 we expect to get the products with at least 1 product in stock not 2.

Add EQUAL to product loop filter by min or max
    - min_stock
    - min and max weight
@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Oct 27, 2015

Member

Thanks !

Member

gillesbourgeat commented Oct 27, 2015

Thanks !

gillesbourgeat added a commit that referenced this pull request Oct 27, 2015

Merge pull request #1750 from lopes-vincent/minmax-filter
Add EQUAL to product loop filter by min or max

@gillesbourgeat gillesbourgeat merged commit a61bb05 into thelia:master Oct 27, 2015

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gillesbourgeat gillesbourgeat added this to the 2.3.0-alpha1 milestone Nov 19, 2015

gillesbourgeat added a commit to gillesbourgeat/thelia that referenced this pull request Jan 6, 2016

gillesbourgeat added a commit to gillesbourgeat/thelia that referenced this pull request Jan 6, 2016

gillesbourgeat added a commit to gillesbourgeat/thelia that referenced this pull request Jan 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment