New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for undefined currency exchange rate #1751

Merged
merged 1 commit into from Nov 15, 2015

Conversation

Projects
None yet
2 participants
@roadster31
Contributor

roadster31 commented Oct 27, 2015

When an exchange rate could not be found the error page was displayed, and the following currencies exchange rate were not updated.

Now, the problem is reported to the user on the currencies page, and the exchange rate update process terminates normally.

img-2015-10-27 09 49 09

The PR also contains a small improvement in the BaseAdminController::errroPage() method, which now logs a the error in the Thelia log.

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Nov 12, 2015

Member

👍 Thanks !

Member

gillesbourgeat commented Nov 12, 2015

👍 Thanks !

gillesbourgeat added a commit that referenced this pull request Nov 15, 2015

Merge pull request #1751 from roadster31/currency-rates-fix
Fix for undefined currency exchange rate

@gillesbourgeat gillesbourgeat merged commit 331c89e into thelia:master Nov 15, 2015

2 checks passed

Scrutinizer 4 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gillesbourgeat gillesbourgeat added this to the 2.3.0-alpha1 milestone Nov 19, 2015

@roadster31 roadster31 deleted the roadster31:currency-rates-fix branch Nov 23, 2015

gillesbourgeat added a commit to gillesbourgeat/thelia that referenced this pull request Jan 6, 2016

:corrlib/Thelange rate, add error message in the currency configurati…
…on page when an exchange rate could not be found (related thelia#1751)

	/Controller/Admin/CurrencyController.php
	templates/backOffice/default/I18n/en_US.php
	templates/backOffice/default/I18n/fr_FR.php

gillesbourgeat added a commit to gillesbourgeat/thelia that referenced this pull request Jan 6, 2016

(related to thelia#1751) Fix for undefined currency exchange rate, ad…
…d error message in the currency configuration page when an
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment