New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for parent attribute of Category loop, and new exclude_parent attribute #1759

Merged
merged 1 commit into from Oct 31, 2015

Conversation

Projects
None yet
2 participants
@roadster31
Contributor

roadster31 commented Oct 28, 2015

This PR fixes the 'parent' attribute of the Category loop, which is described as a list in the Thelia doc.

A new exclude_parent attribute is added.

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Oct 28, 2015

Member

Hello,

Can you change the Thelia documentation please.
Nb : Do not forget the argument from_version

Example :

- {name: "$DECIMAL_SEPARATOR", description: "the lang decimal separator, such as , or .", from_version: "2.2"}

Thank you !

Member

gillesbourgeat commented Oct 28, 2015

Hello,

Can you change the Thelia documentation please.
Nb : Do not forget the argument from_version

Example :

- {name: "$DECIMAL_SEPARATOR", description: "the lang decimal separator, such as , or .", from_version: "2.2"}

Thank you !

@roadster31

This comment has been minimized.

Show comment
Hide comment
@roadster31
Contributor

roadster31 commented Oct 29, 2015

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Oct 31, 2015

Member

Thank you !

Member

gillesbourgeat commented Oct 31, 2015

Thank you !

gillesbourgeat added a commit that referenced this pull request Oct 31, 2015

Merge pull request #1759 from roadster31/category-loop-parent-fix
Fix for parent attribute of Category loop, and new exclude_parent attribute

@gillesbourgeat gillesbourgeat merged commit 69a09ec into thelia:master Oct 31, 2015

2 checks passed

Scrutinizer 1 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gillesbourgeat gillesbourgeat added this to the 2.3.0-alpha1 milestone Nov 19, 2015

@roadster31 roadster31 deleted the roadster31:category-loop-parent-fix branch Nov 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment