New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for prev/next queries in Category, Content and Folder loops #1765

Merged
merged 2 commits into from Nov 4, 2015

Conversation

Projects
None yet
2 participants
@roadster31
Contributor

roadster31 commented Nov 3, 2015

This PR fixes the Prev/Next queries in the Category and Content loops, and add these queries in the Folder loop, where they were missing !

The off-line items are now ignored in these loops, except in the back-end context, where all items are returned, whatever the visibility status is.

@roadster31 roadster31 changed the title from Fixed prev/next item queries to Fixed prev/next queries in Category, Content and Folder loops Nov 3, 2015

@roadster31 roadster31 changed the title from Fixed prev/next queries in Category, Content and Folder loops to Fix for prev/next queries in Category, Content and Folder loops Nov 3, 2015

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Nov 3, 2015

Member

Hello and thank you.

Suggestion : it's possible to apply the same change to the brand loop.

Can you please complete the Thelia documentation.

Thanks !

Member

gillesbourgeat commented Nov 3, 2015

Hello and thank you.

Suggestion : it's possible to apply the same change to the brand loop.

Can you please complete the Thelia documentation.

Thanks !

@roadster31

This comment has been minimized.

Show comment
Hide comment
@roadster31
Contributor

roadster31 commented Nov 4, 2015

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Nov 4, 2015

Member

👍 for the changes in the templates

Thank you !

Member

gillesbourgeat commented Nov 4, 2015

👍 for the changes in the templates

Thank you !

gillesbourgeat added a commit that referenced this pull request Nov 4, 2015

Merge pull request #1765 from roadster31/prex-next-fixes
Fix for prev/next queries in Category, Content and Folder loops

@gillesbourgeat gillesbourgeat merged commit 8db72ff into thelia:master Nov 4, 2015

2 checks passed

Scrutinizer 5 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

gillesbourgeat added a commit to thelia/thelia.github.io that referenced this pull request Nov 5, 2015

@gillesbourgeat gillesbourgeat added this to the 2.3.0-alpha1 milestone Nov 19, 2015

@roadster31 roadster31 deleted the roadster31:prex-next-fixes branch Nov 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment