New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manual order in attributeCombination loop #1778

Merged
merged 1 commit into from Nov 22, 2015

Conversation

Projects
None yet
2 participants
@InformatiqueProg
Contributor

InformatiqueProg commented Nov 16, 2015

See PR #1679 and Issue #1678

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Nov 18, 2015

Member

Hello,

Can you please complete the Thelia documentation.
https://github.com/thelia/thelia.github.io
Specify the version with the from_version argument
Exemple :
gillesbourgeat/thelia.github.io@d00dbe0

Thanks !

Member

gillesbourgeat commented Nov 18, 2015

Hello,

Can you please complete the Thelia documentation.
https://github.com/thelia/thelia.github.io
Specify the version with the from_version argument
Exemple :
gillesbourgeat/thelia.github.io@d00dbe0

Thanks !

@InformatiqueProg

This comment has been minimized.

Show comment
Hide comment
@InformatiqueProg

InformatiqueProg Nov 18, 2015

Contributor

I'll do it,
from Thélia 2.3 and 2.2.2 ?

Contributor

InformatiqueProg commented Nov 18, 2015

I'll do it,
from Thélia 2.3 and 2.2.2 ?

@gillesbourgeat gillesbourgeat added this to the 2.3.0-alpha1 milestone Nov 19, 2015

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Nov 19, 2015

Member

Your pull request is an improvement, so 2.3.

Member

gillesbourgeat commented Nov 19, 2015

Your pull request is an improvement, so 2.3.

InformatiqueProg added a commit to InformatiqueProg/thelia.github.io that referenced this pull request Nov 20, 2015

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Nov 22, 2015

Member

Thanks !

Member

gillesbourgeat commented Nov 22, 2015

Thanks !

gillesbourgeat added a commit that referenced this pull request Nov 22, 2015

Merge pull request #1778 from InformatiqueProg/AttributeCombination-o…
…rder-manuel

Add manual order in attributeCombination loop

@gillesbourgeat gillesbourgeat merged commit 13cc027 into thelia:master Nov 22, 2015

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@InformatiqueProg InformatiqueProg deleted the InformatiqueProg:AttributeCombination-order-manuel branch Nov 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment