New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist only non empty carts #1785

Merged
merged 1 commit into from Nov 25, 2015

Conversation

Projects
None yet
4 participants
@bibich
Contributor

bibich commented Nov 19, 2015

No description provided.

@roadster31

This comment has been minimized.

Show comment
Hide comment
@roadster31

roadster31 Nov 19, 2015

Contributor

👍

Contributor

roadster31 commented Nov 19, 2015

👍

@Soldras

This comment has been minimized.

Show comment
Hide comment
@Soldras

Soldras Nov 19, 2015

Contributor

👍

Contributor

Soldras commented Nov 19, 2015

👍

@bibich bibich added the enhancement label Nov 25, 2015

@bibich bibich added this to the 2.3.0-alpha1 milestone Nov 25, 2015

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Nov 25, 2015

Member

👍 Good job

Please squash your commits.

Thanks !

Member

gillesbourgeat commented Nov 25, 2015

👍 Good job

Please squash your commits.

Thanks !

Fixed issue when we duplicate a cart and try to delete the old one.
Refactored the way the cart is stored in session. just persist non empty cart.

Fixed cart tests

gillesbourgeat added a commit that referenced this pull request Nov 25, 2015

Merge pull request #1785 from bibich/cart
Persist only non empty carts

@gillesbourgeat gillesbourgeat merged commit ea44399 into thelia:master Nov 25, 2015

3 checks passed

Scrutinizer Analysis 1 new issues, 8 updated code elements
Details
Scrutinizer Tests Tests are not configured
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment