New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel update #1792

Merged
merged 1 commit into from Dec 16, 2015

Conversation

Projects
None yet
3 participants
@ThomasArnaud
Contributor

ThomasArnaud commented Nov 23, 2015

The images of the carousel are now saved in the core of Thelia and not in the module.

@roadster31

This comment has been minimized.

Show comment
Hide comment
@roadster31

roadster31 Nov 23, 2015

Contributor

As Carousel is shipped with the Thelia distribution, you should provide the code to migrate existing Carousel installations to the new features (moving images, etc.), so that an update from 2.2 to 2.3 will not break the Carousel.

Contributor

roadster31 commented Nov 23, 2015

As Carousel is shipped with the Thelia distribution, you should provide the code to migrate existing Carousel installations to the new features (moving images, etc.), so that an update from 2.2 to 2.3 will not break the Carousel.

@ThomasArnaud

This comment has been minimized.

Show comment
Hide comment
@ThomasArnaud

ThomasArnaud Nov 24, 2015

Contributor

I wrote an update function that should do that : it copies the carousel images in the new directory if they exist.

Contributor

ThomasArnaud commented Nov 24, 2015

I wrote an update function that should do that : it copies the carousel images in the new directory if they exist.

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Dec 11, 2015

Member

Can you please rebase you pull request.
Thanks

Member

gillesbourgeat commented Dec 11, 2015

Can you please rebase you pull request.
Thanks

@gillesbourgeat gillesbourgeat added this to the 2.3.0-alpha1 milestone Dec 14, 2015

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Dec 14, 2015

Member

Hello,
Can you delete the old files after the duplication.

Member

gillesbourgeat commented Dec 14, 2015

Hello,
Can you delete the old files after the duplication.

gillesbourgeat added a commit that referenced this pull request Dec 16, 2015

@gillesbourgeat gillesbourgeat merged commit 37c5b09 into thelia:master Dec 16, 2015

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment