New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import/export complete rework #1815

Merged
merged 36 commits into from Jan 22, 2016

Conversation

Projects
None yet
4 participants
@bilhackmac
Contributor

bilhackmac commented Nov 30, 2015

This PR is a full rework of import/export.
What I do :

externalize import/export logic from controller
aim the lowest memory footprint during export.
add possibility to import and export from console

@roadster31

This comment has been minimized.

Show comment
Hide comment
@roadster31

roadster31 Nov 30, 2015

Contributor

That's nice ! Does this rework will address the main export problem: export data stored in memory, which make the export unusable when a lot of data has to be exported (see #1352) ?

Contributor

roadster31 commented Nov 30, 2015

That's nice ! Does this rework will address the main export problem: export data stored in memory, which make the export unusable when a lot of data has to be exported (see #1352) ?

@bilhackmac

This comment has been minimized.

Show comment
Hide comment
@bilhackmac

bilhackmac Dec 1, 2015

Contributor

Yes it's one of my objectives

Contributor

bilhackmac commented Dec 1, 2015

Yes it's one of my objectives

@roadster31

This comment has been minimized.

Show comment
Hide comment
@roadster31

roadster31 Dec 1, 2015

Contributor

👍

Contributor

roadster31 commented Dec 1, 2015

👍

@bilhackmac

This comment has been minimized.

Show comment
Hide comment
@bilhackmac
Contributor

bilhackmac commented Jan 19, 2016

@bibich

This comment has been minimized.

Show comment
Hide comment
@bibich

bibich Jan 19, 2016

Contributor

👍
Could you please write a little description for your PR which summarizes the changes.

Contributor

bibich commented Jan 19, 2016

👍
Could you please write a little description for your PR which summarizes the changes.

@Alban-io Alban-io referenced this pull request Jan 20, 2016

Closed

fix export date range #1735

@bilhackmac

This comment has been minimized.

Show comment
Hide comment
@bilhackmac

bilhackmac Jan 22, 2016

Contributor

This PR is a full rework of import/export.
What I do :

  • externalize import/export logic from controller
  • aim the lowest memory footprint during export.
  • add possibility to import and export from console
Contributor

bilhackmac commented Jan 22, 2016

This PR is a full rework of import/export.
What I do :

  • externalize import/export logic from controller
  • aim the lowest memory footprint during export.
  • add possibility to import and export from console

@gillesbourgeat gillesbourgeat changed the title from [WIP] Import/export complete rework to Import/export complete rework Jan 22, 2016

@gillesbourgeat gillesbourgeat added this to the 2.3.0-alpha2 milestone Jan 22, 2016

gillesbourgeat added a commit that referenced this pull request Jan 22, 2016

@gillesbourgeat gillesbourgeat merged commit 64b41e4 into thelia:master Jan 22, 2016

2 checks passed

Scrutinizer 6 new issues, 246 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@roadster31

This comment has been minimized.

Show comment
Hide comment
@roadster31

roadster31 Jan 22, 2016

Contributor

Did you updated the documentation ?

Contributor

roadster31 commented Jan 22, 2016

Did you updated the documentation ?

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Jan 24, 2016

Member

@roadster31 Can you create an issue please.

Member

gillesbourgeat commented Jan 24, 2016

@roadster31 Can you create an issue please.

@bilhackmac bilhackmac deleted the bilhackmac:feature/imports-exports-rework branch Jan 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment