New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add states/provinces concept #1823

Merged
merged 41 commits into from Dec 31, 2015

Conversation

Projects
None yet
3 participants
@bibich
Contributor

bibich commented Dec 2, 2015

馃毀 Work in progress 馃毀

The objective of this PR is to separate states/provinces of countries.
For now, the concept of states/provinces was managed in country model which was not the best way.

With this PR country can have states/provinces managed in a new model State. A lot of related stuff should be modified :

  • addresses / order_addresses
  • tax rules
  • shipping zone
  • delivery module interface
  • a lot of templates to modify
  • configuration page to migrate from previous system, because update can't be done easily and securely.
  • ...

In addition, I added some improvements :

  • country visible or not (state too)
  • better zip code management for country
  • revamp tax rules edit page 馃槺

This is a big PR ( sorry for the review @gillesbourgeat :) ) and there is still some stuff to do, tests to add, ... But if you see anything wrong, tell me !

@gillesbourgeat gillesbourgeat added this to the 2.3.0-alpha1 milestone Dec 4, 2015

@gillesbourgeat gillesbourgeat changed the title from [WIP] Add states/provinces concept to Add states/provinces concept Dec 31, 2015

gillesbourgeat added a commit that referenced this pull request Dec 31, 2015

Merge pull request #1823 from bibich/states
Add states/provinces concept

@gillesbourgeat gillesbourgeat merged commit 2ceaaf1 into thelia:master Dec 31, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@roadster31

This comment has been minimized.

Show comment
Hide comment
@roadster31

roadster31 Dec 31, 2015

Contributor

The schema.xml was changed, but the MySQL Workbench model was not updated.

Could you please update it ?

Contributor

roadster31 commented Dec 31, 2015

The schema.xml was changed, but the MySQL Workbench model was not updated.

Could you please update it ?

@bibich

This comment has been minimized.

Show comment
Hide comment
@bibich

bibich Dec 31, 2015

Contributor

Yes. I'll do it. The documentation too.

Contributor

bibich commented Dec 31, 2015

Yes. I'll do it. The documentation too.

@roadster31

This comment has been minimized.

Show comment
Hide comment
@roadster31

roadster31 Dec 31, 2015

Contributor

Some translations are missing in the B.O. Exemple :

img-2015-12-31 11 27 38

Contributor

roadster31 commented Dec 31, 2015

Some translations are missing in the B.O. Exemple :

img-2015-12-31 11 27 38

@roadster31

This comment has been minimized.

Show comment
Hide comment
@roadster31

roadster31 Dec 31, 2015

Contributor

The tax rule "configuration" (may be renaming it "Applicable Countries ans States" would be better...) is not selected when the tab is clicked, making the form difficult to understand.

img-2015-12-31 11 30 44

Contributor

roadster31 commented Dec 31, 2015

The tax rule "configuration" (may be renaming it "Applicable Countries ans States" would be better...) is not selected when the tab is clicked, making the form difficult to understand.

img-2015-12-31 11 30 44

@bibich

This comment has been minimized.

Show comment
Hide comment
@bibich

bibich Dec 31, 2015

Contributor

For now, translation keys and english translations are present.
I will update Crowdin repo. The french and other languages will be translated on Crowndin and then synced in github.

Contributor

bibich commented Dec 31, 2015

For now, translation keys and english translations are present.
I will update Crowdin repo. The french and other languages will be translated on Crowndin and then synced in github.

@roadster31

This comment has been minimized.

Show comment
Hide comment
@roadster31

roadster31 Dec 31, 2015

Contributor

Well, to be honest, I don't understand at all how "configurations" are working, how to create a new one, or change an existing one.

Contributor

roadster31 commented Dec 31, 2015

Well, to be honest, I don't understand at all how "configurations" are working, how to create a new one, or change an existing one.

@bibich

This comment has been minimized.

Show comment
Hide comment
@bibich

bibich Dec 31, 2015

Contributor

The way it works didn't change. But it's not easy to explain.
The UI has just changed a little.

Contributor

bibich commented Dec 31, 2015

The way it works didn't change. But it's not easy to explain.
The UI has just changed a little.

@roadster31

This comment has been minimized.

Show comment
Hide comment
@roadster31

roadster31 Dec 31, 2015

Contributor

I did not succeed to create a 5.5% tax rule for France M茅tropolitaine. I can't understand how the UI works.

Contributor

roadster31 commented Dec 31, 2015

I did not succeed to create a 5.5% tax rule for France M茅tropolitaine. I can't understand how the UI works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment