New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use routId in url function of UrlGenerator. #1840

Merged
merged 1 commit into from Dec 28, 2015

Conversation

Projects
None yet
6 participants
@Doud63
Contributor

Doud63 commented Dec 11, 2015

add two parameter : routeId and router
default router is router.front or router.admin

@bcbrr

This comment has been minimized.

Show comment
Hide comment
@bcbrr

bcbrr Dec 11, 2015

Contributor

I would suggest using route instead of routeId. This is more consistent with other parameters in my opinion (router is also an id for example).

Contributor

bcbrr commented Dec 11, 2015

I would suggest using route instead of routeId. This is more consistent with other parameters in my opinion (router is also an id for example).

@gillesbourgeat gillesbourgeat changed the title from Use routId in url function of UrlGenerator. to [WIP] Use routId in url function of UrlGenerator. Dec 11, 2015

@gillesbourgeat gillesbourgeat added this to the 2.3.0-alpha1 milestone Dec 15, 2015

Use routId in url function of UrlGenerator.
add two parameter : routeId and router
default router is router.front or router.admin

Change id and router existence test

Change var name id => routeId

Fix sprintf

delete useless throw exception

Change var name router => routerId

Use two variables for router and router identifying

Change parameter routeId for route_id

Add router_id in exception message

Return absolute url

Add automatically router in routerId, and throw exception if router doesn't exist.

@gillesbourgeat gillesbourgeat changed the title from [WIP] Use routId in url function of UrlGenerator. to Use routId in url function of UrlGenerator. Dec 28, 2015

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Dec 28, 2015

Member

Thanks !

Member

gillesbourgeat commented Dec 28, 2015

Thanks !

gillesbourgeat added a commit that referenced this pull request Dec 28, 2015

Merge pull request #1840 from Doud63/feature/routeId-in-smarty-UrlGen…
…erator

Use routId in url function of UrlGenerator.

@gillesbourgeat gillesbourgeat merged commit b6e3839 into thelia:master Dec 28, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment