New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix smarty form_collection_field #1843

Merged
merged 1 commit into from Dec 22, 2015

Conversation

Projects
None yet
3 participants
@Alban-io
Contributor

Alban-io commented Dec 14, 2015

A performance problem was introduced after this PR: #1613 because ​the Form::createView() method create all form view on each call.

This problem comes from ​the fact that TheliaSmarty/Template/Plugins/Form::renderFormCollectionField() doesn't have the current form view field.

My fixed method scan ​the current form field and retrieve this form field view from the parser context current form view.

I'm not convinced this is the right way, I tried with PropertyPath to retrieve the​ form field view but the performance ​was lower.

If anyone has ​another idea ..?

@Alban-io Alban-io changed the title from [WIP] fix smarty render form collection field to [WIP] fix smarty form_collection_field Dec 14, 2015

@Alban-io Alban-io changed the title from [WIP] fix smarty form_collection_field to [WIP] Fix smarty form_collection_field Dec 14, 2015

@gillesbourgeat gillesbourgeat added the bug label Dec 15, 2015

@gillesbourgeat gillesbourgeat added this to the 2.3.0-alpha1 milestone Dec 15, 2015

bibich added a commit that referenced this pull request Dec 22, 2015

Merge pull request #1843 from Alban-io/fix-smarty-render-form-collect…
…ion-field

Fix smarty form_collection_field

@bibich bibich merged commit face2f4 into thelia:master Dec 22, 2015

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gillesbourgeat gillesbourgeat changed the title from [WIP] Fix smarty form_collection_field to Fix smarty form_collection_field Dec 31, 2015

gillesbourgeat added a commit to gillesbourgeat/thelia that referenced this pull request Jan 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment