New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hooks for email template #1850

Merged
merged 4 commits into from Dec 28, 2015

Conversation

Projects
None yet
2 participants
@InformatiqueProg
Contributor

InformatiqueProg commented Dec 17, 2015

PR for issue #1660

InformatiqueProg added some commits Dec 17, 2015

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Dec 17, 2015

Member

Hello,
I'm sorry, i did not say it. For the insert.sql file, there are ranges.
0 - 999 for FrontOffice
1000 - 1999 for BackOffice
2000 - 2999 for PDF
3000 - 3999 for Email

Member

gillesbourgeat commented Dec 17, 2015

Hello,
I'm sorry, i did not say it. For the insert.sql file, there are ranges.
0 - 999 for FrontOffice
1000 - 1999 for BackOffice
2000 - 2999 for PDF
3000 - 3999 for Email

@InformatiqueProg

This comment has been minimized.

Show comment
Hide comment
@InformatiqueProg

InformatiqueProg Dec 17, 2015

Contributor

Ok, i'll change this.
what about email TXT versions ?
new hooks for them too ?

Contributor

InformatiqueProg commented Dec 17, 2015

Ok, i'll change this.
what about email TXT versions ?
new hooks for them too ?

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Dec 17, 2015

Member

👍
for the html templates : email-html.order-confirmation.before-address
for the txt templates : email-txt.order-confirmation.before-address

Member

gillesbourgeat commented Dec 17, 2015

👍
for the html templates : email-html.order-confirmation.before-address
for the txt templates : email-txt.order-confirmation.before-address

InformatiqueProg added some commits Dec 17, 2015

hooks for TXT version + Improvements
- email hooks IDs
- email html hooks rename
- add email txt hooks
- order_confirmation.txt PB product amount
- homogenization emails order TXT
@InformatiqueProg

This comment has been minimized.

Show comment
Hide comment
@InformatiqueProg

InformatiqueProg Dec 17, 2015

Contributor

Seems to be good...

Contributor

InformatiqueProg commented Dec 17, 2015

Seems to be good...

@gillesbourgeat gillesbourgeat added this to the 2.3.0-alpha1 milestone Dec 17, 2015

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Dec 17, 2015

Member

Thanks ! Good contribution !

Member

gillesbourgeat commented Dec 17, 2015

Thanks ! Good contribution !

gillesbourgeat added a commit that referenced this pull request Dec 28, 2015

@gillesbourgeat gillesbourgeat merged commit 78ba354 into thelia:master Dec 28, 2015

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

gillesbourgeat added a commit that referenced this pull request Dec 28, 2015

@InformatiqueProg InformatiqueProg deleted the InformatiqueProg:hooks-in-email-template branch Jan 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment