New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules 'configuration' and 'hook' buttons behavior fix #1921

Merged
merged 1 commit into from Jan 20, 2016

Conversation

Projects
None yet
2 participants
@roadster31
Contributor

roadster31 commented Jan 17, 2016

Until now, the configuration and module-hook buttons of a module were not displayed for an inactive module. Activating the module did not display them: a page reload is required.

This PR fixes the behavior of these buttons, which appear disabled inf the module is inactive, and enabled when the module is active. A reload is no longer required.

img-2016-01-17 18 11 45

@gillesbourgeat gillesbourgeat added this to the 2.3.0-alpha2 milestone Jan 18, 2016

gillesbourgeat added a commit that referenced this pull request Jan 20, 2016

Merge pull request #1921 from roadster31/module-config-display
Modules 'configuration' and 'hook' buttons behavior fix

@gillesbourgeat gillesbourgeat merged commit d3e9437 into thelia:master Jan 20, 2016

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@roadster31 roadster31 deleted the roadster31:module-config-display branch Jan 20, 2016

gillesbourgeat added a commit to gillesbourgeat/thelia that referenced this pull request May 2, 2016

cherry-pick: Modules 'configuration' and 'hook' buttons behavior fix t…
…helia#1921

Conflicts:
	templates/backOffice/default/assets/css/styles.css
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment