New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the prices from a json to a config #1922

Merged
merged 3 commits into from Jan 27, 2016

Conversation

Projects
None yet
4 participants
@ThomasArnaud
Contributor

ThomasArnaud commented Jan 18, 2016

The prices and the freeshipping boolean are now saved in the table module_config.

@roadster31

This comment has been minimized.

Show comment
Hide comment
@roadster31

roadster31 Jan 18, 2016

Contributor

There is a still a consistency problem between colissimo config and areas.

As the config is not stored in a table with a FK to the area table, if an area is deleted, the change is not automatically cascaded to Colissimo config, and there's no listener to handle the change in Colissimo.

Contributor

roadster31 commented Jan 18, 2016

There is a still a consistency problem between colissimo config and areas.

As the config is not stored in a table with a FK to the area table, if an area is deleted, the change is not automatically cascaded to Colissimo config, and there's no listener to handle the change in Colissimo.

@gillesbourgeat gillesbourgeat added this to the 2.3.0-alpha2 milestone Jan 19, 2016

@ThomasArnaud

This comment has been minimized.

Show comment
Hide comment
@ThomasArnaud

ThomasArnaud Jan 20, 2016

Contributor

Thanks for your comment, I added a listener to handle the deletion of an area in the config.

Contributor

ThomasArnaud commented Jan 20, 2016

Thanks for your comment, I added a listener to handle the deletion of an area in the config.

@roadster31

This comment has been minimized.

Show comment
Hide comment
@roadster31

roadster31 Jan 20, 2016

Contributor

👍

Contributor

roadster31 commented Jan 20, 2016

👍

bibich added a commit that referenced this pull request Jan 27, 2016

Merge pull request #1922 from ThomasArnaud/update-colissimo-prices
Move prices configuration from json to db

@bibich bibich merged commit 6cd6337 into thelia:master Jan 27, 2016

2 checks passed

Scrutinizer 9 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bibich

This comment has been minimized.

Show comment
Hide comment
@bibich

bibich Jan 27, 2016

Contributor

Thanks Céline

Contributor

bibich commented Jan 27, 2016

Thanks Céline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment