New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook DI alert messages thrown as exceptions in dev. mode #1928

Merged
merged 1 commit into from Jan 25, 2016

Conversation

Projects
None yet
2 participants
@roadster31
Contributor

roadster31 commented Jan 20, 2016

This PR is a fix for issue #1927. In development mode, the alert messages are also thrown as exceptions, making typos and logic errors much more visible.

This will give an immediate answer to the very common interrogation "why this fscking hook does not show up ?!!", and saves YEARS of accumulated headaches ;)

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Jan 24, 2016

Member

Thanks ! This is also a good idea for many head ;)

Member

gillesbourgeat commented Jan 24, 2016

Thanks ! This is also a good idea for many head ;)

@gillesbourgeat gillesbourgeat added this to the 2.3.0-alpha2 milestone Jan 24, 2016

@roadster31 roadster31 changed the title from Hook DI alert messages thrown in exceptions in dev. mode to Hook DI alert messages thrown as exceptions in dev. mode Jan 24, 2016

gillesbourgeat added a commit that referenced this pull request Jan 25, 2016

Merge pull request #1928 from roadster31/hook-di-exceptions
Hook DI alert messages thrown as exceptions in dev. mode

@gillesbourgeat gillesbourgeat merged commit 9e5c01c into thelia:master Jan 25, 2016

2 checks passed

Scrutinizer 2 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@roadster31 roadster31 deleted the roadster31:hook-di-exceptions branch Jan 27, 2016

gillesbourgeat added a commit to gillesbourgeat/thelia that referenced this pull request May 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment