New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: TaxType class only if extension == php #1946

Merged
merged 1 commit into from Jan 29, 2016

Conversation

Projects
None yet
3 participants
@Asenar
Contributor

Asenar commented Jan 27, 2016

This fix a problem when php.ini files (or any non php file) are present
in core/lib/Thelia/TaxEngine/TaxType/
see http://thelia.net/forum/viewtopic.php?id=11849

Fix: TaxType class only if extension == php
This fix a problem when php.ini files (or any non php file) are present
in core/lib/Thelia/TaxEngine/TaxType/
see http://thelia.net/forum/viewtopic.php?id=11849
@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Jan 29, 2016

Member

Thanks !

Member

gillesbourgeat commented Jan 29, 2016

Thanks !

gillesbourgeat added a commit that referenced this pull request Jan 29, 2016

Merge pull request #1946 from Asenar/fix-taxengine-parsing-onlyphp
Fix: TaxType class only if extension == php

@gillesbourgeat gillesbourgeat merged commit fe39b6b into thelia:master Jan 29, 2016

2 checks passed

Scrutinizer 6 new issues, 3 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Asenar Asenar deleted the Asenar:fix-taxengine-parsing-onlyphp branch Feb 4, 2016

gillesbourgeat added a commit to gillesbourgeat/thelia that referenced this pull request Apr 28, 2016

cherry-pick Fix: TaxType class only if extension == php #1946
This fix a problem when php.ini files (or any non php file) are present
in core/lib/Thelia/TaxEngine/TaxType/
see http://thelia.net/forum/viewtopic.php?id=11849

gillesbourgeat added a commit to gillesbourgeat/thelia that referenced this pull request Apr 28, 2016

cherry-pick: Fix: TaxType class only if extension == php #1946
This fix a problem when php.ini files (or any non php file) are present
in core/lib/Thelia/TaxEngine/TaxType/
see http://thelia.net/forum/viewtopic.php?id=11849

gillesbourgeat added a commit to gillesbourgeat/thelia that referenced this pull request May 2, 2016

cherry-pick: Fix: TaxType class only if extension == php #1946
This fix a problem when php.ini files (or any non php file) are present
in core/lib/Thelia/TaxEngine/TaxType/
see http://thelia.net/forum/viewtopic.php?id=11849
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment