New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a way to get category/product from related content ID #1947

Merged
merged 1 commit into from Jan 29, 2016

Conversation

Projects
None yet
2 participants
@roadster31
Contributor

roadster31 commented Jan 27, 2016

This PR add a "content" parameter to Category and Product loop, so that these loop could return categories / products given a related (= "associated") content ID.

Before this PR, it was not possible to get a product / category form a related content.

* @method int getExcludeProduct()
* @method int[] getParent()
* @method int[] getExcludeParent()
* @method int[] getProduct()

This comment has been minimized.

@gillesbourgeat

gillesbourgeat Jan 28, 2016

Member

Hello,
This changement breaks the method findPk Line 168 and 178, please use findPks and squash your commits ;)

@gillesbourgeat

gillesbourgeat Jan 28, 2016

Member

Hello,
This changement breaks the method findPk Line 168 and 178, please use findPks and squash your commits ;)

@roadster31

This comment has been minimized.

Show comment
Hide comment
@roadster31

roadster31 Jan 29, 2016

Contributor

Done !

Contributor

roadster31 commented Jan 29, 2016

Done !

@gillesbourgeat gillesbourgeat added this to the 2.3.0-alpha2 milestone Jan 29, 2016

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Jan 29, 2016

Member

Thanks !

Member

gillesbourgeat commented Jan 29, 2016

Thanks !

gillesbourgeat added a commit that referenced this pull request Jan 29, 2016

Merge pull request #1947 from roadster31/related-content
Added a way to get category/product from related content ID

@gillesbourgeat gillesbourgeat merged commit dce8248 into thelia:master Jan 29, 2016

2 checks passed

Scrutinizer 6 new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@roadster31 roadster31 deleted the roadster31:related-content branch Jan 29, 2016

gillesbourgeat added a commit to thelia/thelia.github.io that referenced this pull request Mar 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment