New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CartDuplicationEvent to provide both original and duplicated cart to listeners #1970

Merged
merged 3 commits into from Feb 9, 2016

Conversation

Projects
None yet
2 participants
@roadster31
Contributor

roadster31 commented Feb 4, 2016

This PR introduces the CartDuplicationEvent, which stores the original cart so that listeners will get both duplicated and original carts.

Currently, only the duplicated cart is passed, and the listeners have no simple way to get the original one.

CartDuplicationEvent extends CartEvent, thus preserving BC.

@roadster31 roadster31 changed the title from CartDuplicationEvent to privide both original and duplicated cart to listeners to CartDuplicationEvent to provide both original and duplicated cart to listeners Feb 4, 2016

@bibich bibich added this to the 2.3.0-alpha2 milestone Feb 9, 2016

@bibich bibich added the enhancement label Feb 9, 2016

bibich added a commit that referenced this pull request Feb 9, 2016

Merge pull request #1970 from roadster31/cart-dup-event
CartDuplicationEvent to provide both original and duplicated cart to listeners

@bibich bibich merged commit b26815e into thelia:master Feb 9, 2016

2 checks passed

Scrutinizer 2 new issues, 4 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bibich

This comment has been minimized.

Show comment
Hide comment
@bibich

bibich Feb 9, 2016

Contributor

Thanks

Contributor

bibich commented Feb 9, 2016

Thanks

@roadster31 roadster31 deleted the roadster31:cart-dup-event branch Feb 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment