New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module version field length #1980

Merged
merged 2 commits into from Feb 8, 2016

Conversation

Projects
None yet
3 participants
@bilhackmac
Contributor

bilhackmac commented Feb 8, 2016

Update schema to increase module version field to 25 chars.
With only 10 chars update function may be call on each module:refresh, cache:clear commands.

Image your module is at version 1.0.0.beta.2, only 1.0.0.beta was stored.
Image your module is at version 1.0.0.alpha, only 1.0.0.alph was stored.

In both case update function was call for these modules with truncated version as $currentVersion and current (real) version as $newVersion.

For information BaseModule::update signature is

public function update($currentVersion, $newVersion, ConnectionInterface $con = null)

@bibich bibich added the bug label Feb 8, 2016

@bibich bibich added this to the 2.3.0-alpha2 milestone Feb 8, 2016

bibich added a commit that referenced this pull request Feb 8, 2016

@bibich bibich merged commit 74a232d into thelia:master Feb 8, 2016

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bibich

This comment has been minimized.

Show comment
Hide comment
@bibich

bibich Feb 8, 2016

Contributor

Thanks

Contributor

bibich commented Feb 8, 2016

Thanks

@bilhackmac bilhackmac deleted the bilhackmac:fix/module-version branch Feb 8, 2016

gillesbourgeat added a commit to gillesbourgeat/thelia that referenced this pull request May 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment