New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check PHP version before trying to do anything in install process #2001

Merged
merged 2 commits into from Feb 16, 2016

Conversation

Projects
None yet
3 participants
@roadster31
Contributor

roadster31 commented Feb 16, 2016

(same player shoot again)

gillesbourgeat added a commit that referenced this pull request Feb 16, 2016

Merge pull request #2001 from roadster31/php-ver-check
Check PHP version before trying to do anything in install process

@gillesbourgeat gillesbourgeat merged commit 87472c6 into thelia:master Feb 16, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Scrutinizer No new issues
Details

@roadster31 roadster31 deleted the roadster31:php-ver-check branch Feb 16, 2016

@bcbrr

This comment has been minimized.

Show comment
Hide comment
@roadster31

This comment has been minimized.

Show comment
Hide comment
@roadster31

roadster31 Feb 16, 2016

Contributor

No. Old PHP's are failing on use declaration in header.php :

Parse error: syntax error, unexpected T_STRING, expecting T_CONSTANT_ENCAPSED_STRING or '(' in /home/www/*************/web/thelia/web/install/header.php on line 21

21: use Symfony\Component\Translation\Translator;

Contributor

roadster31 commented Feb 16, 2016

No. Old PHP's are failing on use declaration in header.php :

Parse error: syntax error, unexpected T_STRING, expecting T_CONSTANT_ENCAPSED_STRING or '(' in /home/www/*************/web/thelia/web/install/header.php on line 21

21: use Symfony\Component\Translation\Translator;

@gillesbourgeat gillesbourgeat added this to the 2.3.0-alpha2 milestone Feb 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment