New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed translation regexp prefix for templates #2028

Merged
merged 1 commit into from Mar 8, 2016

Conversation

Projects
None yet
2 participants
@roadster31
Contributor

roadster31 commented Mar 5, 2016

The current regexp catches l="invoice.imprint" in {elsehook rel="invoice.imprint"}. The new one don't.

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Mar 8, 2016

Member

👍

A small example for the pdf invoice.html : https://regex101.com/r/uU4pP6/3

Member

gillesbourgeat commented Mar 8, 2016

👍

A small example for the pdf invoice.html : https://regex101.com/r/uU4pP6/3

@gillesbourgeat gillesbourgeat added this to the 2.3.0-alpha2 milestone Mar 8, 2016

gillesbourgeat added a commit that referenced this pull request Mar 8, 2016

Merge pull request #2028 from roadster31/trans-regex-fix
Fixed translation regexp prefix for templates

@gillesbourgeat gillesbourgeat merged commit 8f2b820 into thelia:master Mar 8, 2016

2 checks passed

Scrutinizer 4 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@roadster31 roadster31 deleted the roadster31:trans-regex-fix branch Mar 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment