New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ziparchive not found #2030

Merged
merged 3 commits into from Apr 12, 2016

Conversation

Projects
None yet
2 participants
@Asenar
Contributor

Asenar commented Mar 7, 2016

fix issue #2029

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Mar 8, 2016

Member

Hello,

Did you test these changes on a version 2.2.x of Thelia ?

The class Thelia\Core\Archiver\Archiver\ZipArchiver does not exist in 2.2.x

Member

gillesbourgeat commented Mar 8, 2016

Hello,

Did you test these changes on a version 2.2.x of Thelia ?

The class Thelia\Core\Archiver\Archiver\ZipArchiver does not exist in 2.2.x

@gillesbourgeat gillesbourgeat added this to the 2.3.0-beta2 milestone Apr 12, 2016

@gillesbourgeat gillesbourgeat added the bug label Apr 12, 2016

Asenar added some commits Mar 7, 2016

fixes #2029 use ZipArchiver instead of ZipArchive
and let ZipArchiver class check if ZipArchive is available
Add Thelia ZipArchiver->close() method
This commit is about the issue #2029

@gillesbourgeat gillesbourgeat merged commit caa9b32 into thelia:master Apr 12, 2016

1 of 2 checks passed

Scrutinizer Canceled
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Apr 12, 2016

Member

Thanks !

Member

gillesbourgeat commented Apr 12, 2016

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment