New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collissimo table_exists, closes PR #2053 #2054

Merged
merged 1 commit into from Mar 18, 2016

Conversation

Projects
None yet
2 participants
@Asenar
Contributor

Asenar commented Mar 18, 2016

No description provided.

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Mar 18, 2016

Member

Hello,
You have forgot method the rowCount() after execute(....) ?
If you could apply of CamelCase on the table_exists variable.
Thanks !

Member

gillesbourgeat commented Mar 18, 2016

Hello,
You have forgot method the rowCount() after execute(....) ?
If you could apply of CamelCase on the table_exists variable.
Thanks !

@gillesbourgeat gillesbourgeat added the bug label Mar 18, 2016

@gillesbourgeat gillesbourgeat added this to the 2.3.0-beta1 milestone Mar 18, 2016

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Mar 18, 2016

Member

Thanks !

Member

gillesbourgeat commented Mar 18, 2016

Thanks !

gillesbourgeat added a commit that referenced this pull request Mar 18, 2016

@gillesbourgeat gillesbourgeat merged commit b22ee20 into thelia:master Mar 18, 2016

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Asenar Asenar deleted the Asenar:fix/collissimo_freeshipping_table branch Mar 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment