New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #2059 - Action\TaxRule.php BC break #2060

Merged
merged 1 commit into from Apr 4, 2016

Conversation

Projects
None yet
2 participants
@roadster31
Contributor

roadster31 commented Mar 21, 2016

This PR introduces a method in Action\TaxRule.php to ensure a compatibility with the 2.2.2 country arrays.
In 2.2.2, the TaxRueEvent::getXXXCountryList() methods returned an array of country IDs. [ country ID, country ID ...].
From 2.3.0-alpha1, these functions are expected to return an array of arrays, each one containing a country ID and a state ID. [ [ country ID, state ID], [ country ID, state ID], ...].

The method checks the $obj parameter, and create a 2.3.0-alpha1 compatible return value if $obj is expressed using the 2.2.2 form.

Some sanity checks have also been added.

@gillesbourgeat gillesbourgeat added this to the 2.3.0-beta1 milestone Apr 4, 2016

@gillesbourgeat gillesbourgeat added the BC label Apr 4, 2016

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Apr 4, 2016

Member

Thanks !

Member

gillesbourgeat commented Apr 4, 2016

Thanks !

@gillesbourgeat gillesbourgeat merged commit b52ec7d into thelia:master Apr 4, 2016

2 checks passed

Scrutinizer 1 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@roadster31 roadster31 deleted the roadster31:tax-rule-event-changes-fix branch Apr 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment