New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #2061, minor CS improvements #2063

Merged
merged 1 commit into from Mar 25, 2016

Conversation

Projects
None yet
2 participants
@roadster31
Contributor

roadster31 commented Mar 23, 2016

This is a simple workaround for #2061.

The problem pointed by #2061 still occur if a product is deleted with something like ProductQuery::create()->findPk(some_product_id)->delete();

Moving the free_text_value in a specific table, (and reworking the related code) would be a much better solution.

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Mar 25, 2016

Member

Thanks !

Member

gillesbourgeat commented Mar 25, 2016

Thanks !

@gillesbourgeat gillesbourgeat added this to the 2.3.0-beta1 milestone Mar 25, 2016

@gillesbourgeat gillesbourgeat merged commit 567dca7 into thelia:master Mar 25, 2016

2 checks passed

Scrutinizer 2 new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@roadster31 roadster31 deleted the roadster31:free_text_feature_fix branch Apr 4, 2016

gillesbourgeat added a commit to gillesbourgeat/thelia that referenced this pull request May 2, 2016

cherry-pick: Fix for thelia#2061, minor CS improvements thelia#2063
Conflicts:
	core/lib/Thelia/Controller/Admin/ProductController.php

roadster31 referenced this pull request May 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment