New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed checkbox and radio automatic rendrering #2078

Merged
merged 1 commit into from Apr 1, 2016

Conversation

Projects
None yet
2 participants
@roadster31
Contributor

roadster31 commented Mar 30, 2016

The "checked" status of checkboxes and radios was not correctly managed by form-field-attributes-renderer.html

This PR fixes the problem, and removes an extra "true" string that was floating around.

@gillesbourgeat gillesbourgeat added this to the 2.3.0-beta1 milestone Apr 1, 2016

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Apr 1, 2016

Member

Hello,
Can you squash your commits !
Thanks !

Member

gillesbourgeat commented Apr 1, 2016

Hello,
Can you squash your commits !
Thanks !

@roadster31

This comment has been minimized.

Show comment
Hide comment
@roadster31

roadster31 Apr 1, 2016

Contributor

Done !

Contributor

roadster31 commented Apr 1, 2016

Done !

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Apr 1, 2016

Member

Thanks !

Member

gillesbourgeat commented Apr 1, 2016

Thanks !

@gillesbourgeat gillesbourgeat merged commit c868a06 into thelia:master Apr 1, 2016

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@roadster31 roadster31 deleted the roadster31:form-field-renderer-fix branch Apr 4, 2016

gillesbourgeat added a commit to gillesbourgeat/thelia that referenced this pull request May 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment