New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed and improved cancel order processing #2097

Merged
merged 1 commit into from Apr 11, 2016

Conversation

Projects
None yet
2 participants
@roadster31
Contributor

roadster31 commented Apr 8, 2016

The order_id parameter of the Front\Controller\OrderController::orderFailed() method was ignored, in favor of the order_id request parameter. This behavior is wrong as the current request may not contains an order_id parameter.

Additionally, in some cases, the payment module does not return an order ID when the order is canceled by the client. Now, this situation is smoothly processed, and the order-cancel page is displayed instead of an error page.

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Apr 11, 2016

Member

Hello,
Can you rebase this pull request.

Member

gillesbourgeat commented Apr 11, 2016

Hello,
Can you rebase this pull request.

@gillesbourgeat gillesbourgeat added the bug label Apr 11, 2016

@gillesbourgeat gillesbourgeat added this to the 2.3.0-beta2 milestone Apr 11, 2016

@gillesbourgeat

This comment has been minimized.

Show comment
Hide comment
@gillesbourgeat

gillesbourgeat Apr 11, 2016

Member

Thanks !

Member

gillesbourgeat commented Apr 11, 2016

Thanks !

@gillesbourgeat gillesbourgeat merged commit 43dc457 into thelia:master Apr 11, 2016

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@roadster31 roadster31 deleted the roadster31:ordercancelfix branch Apr 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment